Problem/Motivation

We are using the prlp module on several of our websites that we want to migrate to Drupal 11.

Proposed resolution

Implement a Drupal 11 compatible version of this module.

Remaining tasks

Publish and validate MR.

Create a new major 2.0.0 release (PrlpController constructor signature change).

Testing on Drupal 11

To test on Drupal 11, add the following lines to your composer.json repositories section:

  "repositories": [
    {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/prlp-3477501.git"
    },

and then run:

composer require drupal/prlp:dev-3477501-automated-drupal-11
CommentFileSizeAuthor
#6 prlp-pipeline-results-1.jpg76.2 KBmably

Issue fork prlp-3477501

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mably created an issue. See original summary.

mably opened merge request !18

mably’s picture

mably commented
Title: Automated Drupal 11 compatibility fixes for prlp » Drupal 11 compatibility fixes for prlp
Issue summary: View changes
mably’s picture

mably commented
Issue summary: View changes
mably’s picture

mably commented
Issue summary: View changes
mably’s picture

mably commented
Assigned: mably » Unassigned
Status: Active » Needs review
StatusFileSize
new prlp-pipeline-results-1.jpg76.2 KB

All green 🎉

PRLP pipeline results

  • mably committed f2217e91 on 2.0.x 
    Issue #3477501 by mably: Drupal 11 compatibility fixes for prlp
ccrawford91’s picture

ccrawford91 commented
Status: Needs review » Fixed
elc’s picture

elc commented

Having looked at the code code changes for this issue and the 2.0.x branch, it is still quite compatible with Drupal 10.3. I can see it discussed in passing in this issue, but there does not seem to be a reason for dropping the older versions, not even D10 which is still actively supported core.

Could 10.3 be added to the supported cores on the 2.0.x branch? ie core_version_requirement: ^10.3 || ^11

This would allow for an easier upgrade between Drupal 10 and 11, as all of the modules can be updated to be compatible with D11 core, before the final push to switching over the core. At present, it has to be updated at the same time as core, tying the two together.

Also, the drupal/core requirement should be removed from the composer.json file. This is automatically generated from the contents of the info.yml core_version_requirement, making it a double up and possible future conflict if one of them is accidentally not updated.

ccrawford91’s picture

ccrawford91 commented

@elc I believe you are correct.

Are you able to create a patch / PR which includes those changes?

elc opened merge request !19

elc’s picture

elc commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Fixed » Needs review

Updating target version. Tests pass for all target cores. Setting to NR as this MR amends the D11 fixes.

elc’s picture

elc commented
Status: Needs review » Fixed

Fixed in 2.0.1 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.