Problem/Motivation

Call to deprecated method setVariants() of class Drupal\simple_sitemap\Manager\EntityManager. Deprecated in simple_sitemap:4.1.7 and is removed from simple_sitemap:5.0.0. Use setSitemaps() instead.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

windy-ux created an issue. See original summary.

s3b0un3t’s picture

Status: Active » Needs work

Hello !

I've tested your changes. It's ok for installing project but an error occurs on config form :
ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/web/modules/contrib/domain_simple_sitemap/src/Form/DomainSimpleSitemapConfigForm.php on line 73 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

It seems to be a Drupal 11 compatibility error.

keithlee_giai’s picture

@s3b0un3t, I can make it work by commenting out __construct in the function temporarily, but indeed it occurs to all modules relying on Drupal core's configform.

hosterholz made their first commit to this issue’s fork.

hosterholz’s picture

Status: Needs work » Needs review

marcoliver made their first commit to this issue’s fork.

marcoliver’s picture

Status: Needs review » Reviewed & tested by the community

Tested the issue fork with the change provided by @hosterholz. It fixes the error on the form.

I also fixed a small phpcs issue introduced through the last commit.

Marking RTBC.

d.fisher’s picture

Priority: Normal » Critical

+1 RTBC. Any chance we can get this merged and a tagged release for Drupal 11?

i-trokhanenko made their first commit to this issue’s fork.

i-trokhanenko’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.