Problem/Motivation
Call to deprecated method setVariants() of class Drupal\simple_sitemap\Manager\EntityManager. Deprecated in simple_sitemap:4.1.7 and is removed from simple_sitemap:5.0.0. Use setSitemaps() instead.
Issue fork domain_simple_sitemap-3476402
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #5
s3b0un3tHello !
I've tested your changes. It's ok for installing project but an error occurs on config form :
ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/web/modules/contrib/domain_simple_sitemap/src/Form/DomainSimpleSitemapConfigForm.php on line 73 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of core/lib/Drupal/Core/Form/ConfigFormBase.php).It seems to be a Drupal 11 compatibility error.
Comment #6
keithlee_giai commented@s3b0un3t, I can make it work by commenting out __construct in the function temporarily, but indeed it occurs to all modules relying on Drupal core's configform.
Comment #8
hosterholzComment #10
marcoliverTested the issue fork with the change provided by @hosterholz. It fixes the error on the form.
I also fixed a small phpcs issue introduced through the last commit.
Marking RTBC.
Comment #11
d.fisher commented+1 RTBC. Any chance we can get this merged and a tagged release for Drupal 11?
Comment #14
i-trokhanenkoCommitted, thanks!