Problem/Motivation

In conversion process from UI Patterns 1.x, meta:enum is always created, even when the keys and values are identical.

Steps to reproduce

Don't create meta:enum when the keys and values are identical.

Issue fork ui_patterns-3475962

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !222

pdureau’s picture

pdureau commented
Status: Active » Needs work

Done.

However, something to check before: Is it OK than meta:enum doesn't always have the same keys as enum?

There is no established standard to check.

Let's check those implementations:

pdureau’s picture

pdureau commented
Title: [2.0.0-beta3] Cleaner meta:enum conversion » [2.0.0-beta4] Cleaner meta:enum conversion
pdureau’s picture

pdureau commented

Decision: let's remove meta:enum only of ALL items are identical between key & value

So, this is OK (because it looks deliberate):

'meta:enum':
  sm: Small
  md: md
  lg: lg
pdureau’s picture

pdureau commented
Status: Needs work » Reviewed & tested by the community

Waiting the pipeline to be executed

  • pdureau committed 15bcea00 on 2.0.x 
    Issue #3475962 by pdureau: Cleaner meta:enum conversion
pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.