Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

sunil jolapara created an issue. See original summary.

sunil jolapara’s picture

Status: Needs work » Needs review
clarkssquared’s picture

Status: Needs review » Needs work

Hi

I tested your MR !3 and I can still see some PHPCS issues in the module

➜  paragraphs_summary git:(main) ✗ curl https://git.drupalcode.org/project/paragraphs_summary/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4231    0  4231    0     0   6990      0 --:--:-- --:--:-- --:--:--  7039
patching file 'src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php'
➜  paragraphs_summary git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml paragraphs_summary 

FILE: ...l_local/web/modules/contrib/paragraphs_summary/paragraphs_summary.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------


FILE: ...phs_summary/src/Plugin/Field/FieldFormatter/ParagraphsSummaryFormatter.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
 132 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 144 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 148 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 152 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 160 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 166 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 180 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 183 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 190 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 197 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 200 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 201 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
--------------------------------------------------------------------------------

Time: 215ms; Memory: 10MB

➜  contrib git:(main) ✗ 
avpaderno’s picture

Version: 1.2.0 » 1.x-dev
Issue tags: +Needs issue summary update

The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

avpaderno’s picture

Assigned: » Unassigned
cleavinjosh’s picture

Assigned: Unassigned » cleavinjosh

cleavinjosh’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update

cleavinjosh changed the visibility of the branch 3475739-phpcs-issues to hidden.

cleavinjosh’s picture

cleavinjosh’s picture

Assigned: cleavinjosh » Unassigned
Status: Needs work » Reviewed & tested by the community

opi’s picture

Status: Reviewed & tested by the community » Fixed

Thanks everyone ; Merge train has arrived, I will create a new minor release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.