Problem/Motivation

In #3252386: Use PHP attributes instead of doctrine annotations we added support for attribute based plugin discovery.
As part of that issue we converted block and action plugins.

This issue is to convert \Drupal\patternkit\Annotation\PatternFieldProcessorplugins and \Drupal\patternkit\Annotation\PatternLibrary to use Attributes.

Proposed resolution

  1. Add a class to represent the new Attributes - Example
  2. Update the plugin manager constructor to include both the attribute and annotation class names - example
  3. Convert all plugins that use the annotation to use the new attribute - example

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork patternkit-3475637

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

slucero created an issue. See original summary.

slucero’s picture

Status: Active » Needs review
petermallett’s picture

Status: Needs review » Reviewed & tested by the community

  • slucero committed dc1b6da7 on 9.1.x
    Issue #3475637 by slucero, petermallett: Convert Patternkit Custom...
slucero’s picture

Status: Reviewed & tested by the community » Fixed

Merged for inclusion in the 1.0 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.