Problem/Motivation

We are not using pnpm for a long time now, lock files are removed, etc. We should also remove pnpm from build step in package.json:

"build-install": "((type pnpm && pnpm install) || npm install)",

Issue fork bs_base-3473974

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Version: 2.x-dev » 8.x-1.x-dev

Actually just figured we removed it from our custom child themes that are using bs_bootstrap theme. However I just noticed we still have pnpm-lock.yaml in bs_base and it is making problems if you used `npm install` and then `npm run build` which will try to use pnpm first if available and throw all kind of errors because of previous `npm install`.

Also npm feels much faster now and there are no benefits using pnpm in ddev enviroment, so let's remove pnpm support now and not latter. You can still use it in your custom themes if needed, just edit your child themes package.json and bring back pnpm there in build scripts.

pivica opened merge request !6

  • pivica committed 328254f0 on 8.x-1.x 
    Issue #3473974 by pivica: Remove pnpm support from build scripts
pivica’s picture

pivica commented
Status: Active » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.