Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
As per #3434087: Automated Drupal 11 compatibility fixes for rabbit_hole D11 support was added to 8.x-1.x but not 2.0.x
Tests are also failing on this branch.
Issue fork rabbit_hole-3471713
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
acbramley commentedAfter a lot of faffing about trying to get previous major to work I realised that I'm dropping D9 support here anyway so it's going to fail... This is ready for a review.
Comment #4
smustgrave commentedIf a new branch was started could drop the deprecated modules.
Comment #5
acbramley commented@smustgrave yeah I think that's a good idea, or perhaps just 2.1.x, since we're also dropping core versions here. That'd also mean we could ditch the upgrade path tests which are failing on next major
Comment #6
dqd@acbramley: thanks for working on it _/\_ - I was about to open it and found it in this minute 1+
Comment #7
dqdRTBC from me +1 Applied cleanly so far. Needs maybe deeper code review if more manual changes are required/wanted, but I tend to think of separate issues for that to keep the bot issues cleaned and narrowed.
Comment #8
ankitv18 commentedLeft some suggestions over MR ~~ please consider
Leaving this in review for any other suggestions.
Comment #10
japerryTheres no reason to drop D9.5 support yet, and I don't think we need to make a new major yet either.
Remember, 2.x is still in alpha, and has minimal usage vs 1.x. I think the conversation in #3385471: 'rh_action' not found highlights the importance of keeping these deprecated modules for the forseeable future, infact it looks like some missing ones need to be added back.
Tour was added as part of the migration fixture, which is failing in Drupal 11 tests. I don't see any place where tour is being actually used in the fixture, so I removed it.
Will wait for tests to pass, and if so will commit!
Comment #11
japerryBleh, it looks like the update fixture needs to be rebuilt. It also is missing a few of the old sub-module test cases, which is probably why users are finding failures when upgrading with the sub modules being enabled.
Comment #12
d.fisher commentedCan I help test this at all? If so what needs work here? Would be great to get D11 compatibility on 2.x!
Comment #14
rodrigoaguileraI attempted to fix the tests by adding the tour module that became a contrib module but there is more failures.
I guess the Drupal 9 fixture is trying to upgrade directly to Drupal 11 and that creates situations like the help_topics module to be uninstalled (current test failure).
So probably adding the tour module was not a step in the right direction.
I feel the proper solution is to create a fixture that starts from Drupal 10, therefore dropping support for the upgrade path from Drupal 9.
People coming from rabbit hole v1 on Drupal 9 need to upgrade first to Drupal 10.
Comment #16
rhezios commentedI've updated the used fixture to disable the tour and help modules. The test goal is to validate the config update within the Rabbit hole module. Therefore we don't need the extra test dependencies. After that we still unable to run the necessary update hooks (within the test). This is because of the removed core hooks which are required to be able to update.
I created an additional fixture (Drupal 10.3) to support next (Drupal 11) version. The 9.5 fixtures is used by the previous and current Drupal version tests.
I'm not sure if both versions are required to solve the problem.
Comment #18
borisson_Tests are happy about the latest pull request. I think this can go in.
Comment #19
rajab natshahComment #21
acbramley commentedhttps://www.drupal.org/project/rabbit_hole/releases/2.0.0-beta1 is D11 compatible, thanks @japerry!