This patch replaces the use of theme('table') to display the devel query log with a custom theme function which uses div's and CSS positioning. The motivation for this patch was to reduce the overhead and rendering cost in many browsers to display the query log. Large tables in particular are very expensive to render as the actual metrics of the table can only be determined after all of the content has been loaded.

Patched against CVS checkout of 6.x-1.x-dev (Dec 14, 2008).

CommentFileSizeAuthor
#5 d7_querylog.patch3.77 KByhahn
#3 mw.patch4.58 KBmoshe weitzman
devel_querylog.patch.txt4.23 KByhahn

Comments

moshe weitzman’s picture

moshe weitzman commented

Terrific. Also, the table sticky header for was driving me crazy too. Hope some folks can review this soon. If not, I will probably just commit the patch and wait for feedback.

neochief’s picture

neochief commented
Status: Needs review » Reviewed & tested by the community

Works fine for me

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new mw.patch4.58 KB

I fixed the patch so it would apply cleanly (see attached) but the target column slips down into a new row ruining the layout. tested on Safari.

yhahn’s picture

yhahn commented

Hey Moshe,

Can you tell me more (or attach a screenshot) of the described behavior? I don't have the option of running Safari on my linux install here but I'll try to poke a colleague into helping debug : )

yhahn’s picture

yhahn commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new d7_querylog.patch3.77 KB

This patch adds CSS for the new target column in D7.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs work » Fixed

Committed to D6 and HEAD. I missed the fact that the original patch was for D6. Sorry about that.

Many thanks. I much look forward to more of your patches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

hass’s picture

hass commented
Status: Closed (fixed) » Postponed (maintainer needs more info)

This was not a "layout table"... Since what day are we not using tables for table data? Table data need to go into tables and not DIVs. This does not comply with accessibility rules as I know.

moshe weitzman’s picture

moshe weitzman commented
Status: Postponed (maintainer needs more info) » Closed (fixed)
hass’s picture

hass commented
Status: Closed (fixed) » Active

No feedback, reopen

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Closed (fixed)

@hass - please do not override maintainer's final status. you are welcome to be the last word in your own projects.

powrsurg’s picture

powrsurg commented
Issue summary: View changes

@moshe wizman - I think hass' update was actually appropriate. The comments by hass were appropriate and accurate. Converting from a table to a div based structure made this module inaccessible for developers with disabilities.

If a div based structure is desired then ARIA landmark roles must be added to remake the pseudo-table accessible.