Problem/Motivation
The theme is currently not Drupal 11 ready.
Steps to reproduce
Proposed resolution
Let's add the Drupal 11 support.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3469444-zurb-foundation-d11.patch | 728 bytes | nmillin |
Issue fork zurb_foundation-3469444
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
grevil commentedComment #4
grevil commentedAccording to upgrade_status and phpstan, this should be it!
Comment #5
tjtj commentedSo how do I get a D11 version?
Comment #6
tjtj commentedComment #7
tjtj commentedWebform has now been updated, and users of your theme cannot update to Drupal 11! Please update it.
Comment #8
nmillin commentedIf people want to get to D11 with zurb_foundation before this gets into the project, check out https://gorannikolovski.com/blog/how-to-upgrade-drupal-9-to-10#how-to-in.... It has nice steps on how to use https://github.com/mglaman/composer-drupal-lenient.
PS - https://git.drupalcode.org/project/zurb-foundation/-/merge_requests/30.p... is the patch that you can download and use OR I've attached a current copy.
Comment #9
tjtj commentedWhy can't you just release this? Patching requires munging with composer.json.
Comment #10
tjtj commentedI was unable to get the patch to work in composer.json
so I unstalled ZF and was able to update to 11.1.2.
Then I reinstalled the theme manually (from the tar file) and applied your patch.
But, in D11, Slick slideshow no longer works, so you must switch to splide to get the slideshow to work!
Comment #12
sim_1Thank you @grevil for your help with this patch!
@tjtj sounds like you've found new issues in D11 with this theme. Please feel free to write up new issues in the issue queue for anything you find.
Thanks!
Comment #13
sim_1Thank you @nmillin also for you help with the interim patching steps!