Problem/Motivation

The theme is currently not Drupal 11 ready.

Steps to reproduce

Proposed resolution

Let's add the Drupal 11 support.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3469444-zurb-foundation-d11.patch728 bytesnmillin
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

grevil created an issue. See original summary.

grevil’s picture

Assigned: Unassigned » grevil

grevil’s picture

Assigned: grevil » Unassigned
Status: Active » Needs review

According to upgrade_status and phpstan, this should be it!

tjtj’s picture

So how do I get a D11 version?

tjtj’s picture

Priority: Normal » Major
tjtj’s picture

Webform has now been updated, and users of your theme cannot update to Drupal 11! Please update it.

nmillin’s picture

StatusFileSize
new728 bytes

If people want to get to D11 with zurb_foundation before this gets into the project, check out https://gorannikolovski.com/blog/how-to-upgrade-drupal-9-to-10#how-to-in.... It has nice steps on how to use https://github.com/mglaman/composer-drupal-lenient.

PS - https://git.drupalcode.org/project/zurb-foundation/-/merge_requests/30.p... is the patch that you can download and use OR I've attached a current copy.

tjtj’s picture

Why can't you just release this? Patching requires munging with composer.json.

tjtj’s picture

I was unable to get the patch to work in composer.json

    "extra": {
       "patches": {
           "drupal/zurb_foundation": {
               "temporary patch": "https://git.drupalcode.org/project/zurb-foundation/-/merge_requests/30.patch"
           }
       },

so I unstalled ZF and was able to update to 11.1.2.
Then I reinstalled the theme manually (from the tar file) and applied your patch.

But, in D11, Slick slideshow no longer works, so you must switch to splide to get the slideshow to work!

  • sim_1 committed fba6da7f on 9.x authored by grevil
    Issue #3469444: Add Drupal 11 compatibility
    
sim_1’s picture

Status: Needs review » Fixed

Thank you @grevil for your help with this patch!

@tjtj sounds like you've found new issues in D11 with this theme. Please feel free to write up new issues in the issue queue for anything you find.

Thanks!

sim_1’s picture

Thank you @nmillin also for you help with the interim patching steps!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.