Problem/Motivation

With the recent release of Drupal 11 and soon to become the default version of Drupal, the Fontawesome_iconpicker module is currently not compatible with Drupal 11.

Steps to reproduce

N/A

Proposed resolution

Make the module compatible with Drupal 11.

Remaining tasks

Make it compatible with Drupal 11.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#5 module-compatible-3467865-5-AFTER.png75.73 KBchandansha
#5 module-compatible-3467865-5-BEFORE.png66.58 KBchandansha
#3 Make_the_module_compatible_with_Drupal_11-3467865.patch445 bytesananya.k

Issue fork fontawesome_iconpicker-3467865

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mariohernandez created an issue. See original summary.

ananya.k’s picture

ananya.k commented
Assigned: Unassigned » ananya.k
ananya.k’s picture

ananya.k commented
Status: Active » Needs review
StatusFileSize
new Make_the_module_compatible_with_Drupal_11-3467865.patch445 bytes

please refer to attached patch.

ananya.k’s picture

ananya.k commented
Assigned: ananya.k » Unassigned
chandansha’s picture

chandansha commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new module-compatible-3467865-5-BEFORE.png66.58 KB
new module-compatible-3467865-5-AFTER.png75.73 KB

I have tested #3 Patch. Now module compatible for drupal 11.
I move it to RTBC.
THANKS!!

d34dman’s picture

d34dman commented

@Chandansha,
Did you test if the module actually works in Drupal 11? The patch is just making the module "installable" for Drupal 11. Not same as it works for Durpal 11.

d34dman’s picture

d34dman commented
Status: Reviewed & tested by the community » Needs review

Adding this to "needs review" since the comment in #5 doesn't seems to cover the user testing.

chandansha’s picture

chandansha commented

@D34dMan,
Sorry, I just check this module is Install in drupal 11 or not.

gurrmag’s picture

gurrmag commented

I've installed this on 11.0.4.

Two issues:
1. The picker appears top left corner of the screen. Changing CSS on the contained to position relative seems to fix this.
2. When you select something from the picker, the icon text field is not populated.

interlated made their first commit to this issue’s fork.

d34dman’s picture

d34dman commented

@gurrmag, in which "theme" are you experiencing the issue?

  • d34dman committed bdada025 on 3.x 
    Issue #3467865 by mariohernandez: Make the module compatible with Drupal...
d34dman’s picture

d34dman commented
d34dman’s picture

d34dman commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.