Problem/Motivation

Add PHPMD default codesize rule to CI.

Issue fork ui_patterns-3464879

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

mogtofu33 opened merge request !160

mogtofu33’s picture

mogtofu33 commented
Status: Active » Needs review
pdureau’s picture

pdureau commented
Title: [2.0.0-beta2] Ci add PHPMD job » [2.0.0-beta1] Ci add PHPMD job

Let's merge it in beta1

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

the MR looks nice, could we just add the parameter on phpmd command line to use .phpmd.xml in the project root?
maybe it is already the case, i just wanted to be sure.
thank you :)

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Needs review » Needs work
mogtofu33’s picture

mogtofu33 commented
Status: Needs work » Needs review

I didn't notice the config file, fixed.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Needs review » Reviewed & tested by the community

many thanks, i merge, that's a super new addition to the pipeline :)

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Reviewed & tested by the community » Fixed
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: mogtofu33 » Unassigned
pdureau’s picture

pdureau commented
Status: Fixed » Closed (fixed)