Problem/Motivation

The migration process (drush upm) doesn't need the theme to be activated except for the "preview to story" task which is loading already migrated SDC components.

For example, if only ui_suite_uswds is activated and we run drush upm ui_suite_bootstrap, the migrtaion will run well but for each call to component render element in stories if the component exists in both ui_suite_uswds and ui_suite_bootstrap, ui_suite_uswds one will be called instead of ui_suite_bootstrap.

Proposed resolution

Test if the theme is not activated before running the migration, stop the process and print a message.

Issue fork ui_patterns-3464869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Assigned: Unassigned » smustgrave

May be something I can tackle

pdureau’s picture

pdureau commented
Assigned: smustgrave » pdureau
pdureau’s picture

pdureau commented

if possible, do also the remaining @todo in ui_patterns_legacy:

  • ComponentWriter: copy preview template somewhere else in templates/ > no, alert instead
  • ComponentWriter: alert if variant templates are found
  • @tood better rules : no need for betetr rules?

pdureau opened merge request !206

  • pdureau committed 1d618258 on 2.0.x 
    Issue #3464869 by pdureau: Wrong component ID in stories
pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Active » Fixed
pdureau’s picture

pdureau commented
Status: Fixed » Closed (fixed)