Problem/Motivation

As noted in similar issues in the queues for other third-party modules (e.g., https://www.drupal.org/project/patternkit/issues/3259629)... "in order to use the Monolog module on a Drupal 8 site, services must inject based on the LoggerInterface and not LoggerChannelInterface."

Proposed resolution

Use Psr\Log\LoggerInterface;

CommentFileSizeAuthor
#4 3464500-fix-logger-class-4.patch1.86 KBbeunerd

Issue fork tfa-3464500

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

beunerd created an issue. See original summary.

beunerd’s picture

beunerd commented
Issue summary: View changes

beunerd opened merge request !86

beunerd’s picture

beunerd commented
Assigned: beunerd » Unassigned
Status: Active » Needs review
StatusFileSize
new 3464500-fix-logger-class-4.patch1.86 KB

Here's a patch, and the MR is in too.

cmlara’s picture

cmlara
he/him
commented
Version: 8.x-1.7 » 2.x-dev
Status: Needs review » Needs work

NW for PHPCS changes (stray “;” and use order alphabetical)

We also need to commit this to 2.x which will likely require a separate MR.

We are fully MR so no need to post patch files when updating.

Sourav_Paul made their first commit to this issue’s fork.

Sourav_Paul opened merge request !87

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Status: Needs work » Needs review
cmlara’s picture

cmlara
he/him
commented
Title: TypeError: Drupal\tfa\Commands\TfaTokenManagement::__construct(): Argument #4 ($logger) must be of type Drupal\Core\Logger\LoggerChannelInterface, Psr\Log\NullLogger given in Drupal\tfa\Commands\TfaTokenManagement->__construct() » TfaTokenManagement::__construct(): Argument #4 ($logger) should allow \Psr\Log\LoggerInterface

  • cmlara committed a11f0f4b on 2.x authored by sourav_paul 
    Issue #3464500 by sourav_paul, beunerd, cmlara: TfaTokenManagement::...

  • cmlara committed 176628c7 on 8.x-1.x authored by beunerd 
    Issue #3464500 by sourav_paul, beunerd, cmlara: TfaTokenManagement::...
cmlara’s picture

cmlara
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.