Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork interval-3464101

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

larowlan’s picture

samitk’s picture

Status: Active » Needs review

Fixed failed phpunit test cases.

Thanks
Samit K.

  • larowlan committed fc465a86 on 8.x-1.x
    Issue #3464101 by larowlan, samit.310@gmail.com, anoopsingh92,...
larowlan’s picture

Status: Needs review » Fixed

d11 here we come, 21 modules down, 38 to go

tomtech’s picture

Status: Fixed » Needs work

This change does a lot more than just add gitlabci. :)

This commit breaks sites running 9.x and 10.x prior to 10.3, since it uses the new Base classes introduced in 10.3.

Since the deprecated classes won't actually be removed until D12, seems those changes should reverted.

Specifically:

-use Drupal\Core\Render\Element\FormElement;
+use Drupal\Core\Render\Element\FormElementBase;

and

-class Interval extends FormElement {
+class Interval extends FormElementBase {

Then, a new version that only supports 10.3 or later can be created with these changes.

larowlan’s picture

Thanks, can do - are you able to create an MR?

tomtech’s picture

@larowlan

I can create an MR, yes.

  • larowlan committed 63f06c13 on 8.x-1.x authored by TomTech
    Issue #3464101 by larowlan, samit.310@gmail.com, TomTech, anoopsingh92,...
larowlan’s picture

Status: Needs work » Fixed

Thanks @TomTech - I'm tagging 8.x-1.14 now

larowlan’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.