Test are currently not passing for "phpunit (next minor)".

Issue fork webform-3463350

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3463350-fix-test-failures Comparechanges, plain diff MR !499
  • 6.x Comparecompare
  • 6.3.x Comparecompare

Comments

Liam Morland created an issue. See original summary.

liam morland’s picture

Issue summary: View changes

liam morland’s picture

Version: 6.2.x-dev » 6.3.x-dev
Issue summary: View changes

Test should now be passing. The failures for non-"next minor" versions appear to be temporary. Testing for "next minor" should be enabled and made to pass.

liam morland’s picture

There is a failure in WebformElementMediaFileTest. The failure is that it fails to find a specific string in the HTML. It could be something simple like the elements being in rendered in a different order. If this test was switched to XPath, differences like that would not matter and the test would pass.

It would be helpful if there was a way to see the failed output.

acbramley made their first commit to this issue’s fork.

acbramley’s picture

Status: Active » Needs review

Rebased against HEAD and fixed the tests by using elementExists.

acbramley’s picture

It's green! 🎉

nicxvan’s picture

Status: Needs review » Reviewed & tested by the community

Changes look good, tests are indeed passing and the changes are test only converting from responseContains to elementExists which is the right way to check.

I also confirmed each assertion is still acting on the same element.

liam morland’s picture

Status: Reviewed & tested by the community » Fixed

Thanks very much!

liam morland’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nicxvan’s picture