Test are currently not passing for "phpunit (next minor)".
Issue fork webform-3463350
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
liam morlandComment #4
liam morlandTest should now be passing. The failures for non-"next minor" versions appear to be temporary. Testing for "next minor" should be enabled and made to pass.
Comment #9
liam morlandThere is a failure in WebformElementMediaFileTest. The failure is that it fails to find a specific string in the HTML. It could be something simple like the elements being in rendered in a different order. If this test was switched to XPath, differences like that would not matter and the test would pass.
It would be helpful if there was a way to see the failed output.
Comment #11
acbramley commentedRebased against HEAD and fixed the tests by using elementExists.
Comment #12
acbramley commentedIt's green! 🎉
Comment #13
nicxvan commentedChanges look good, tests are indeed passing and the changes are test only converting from responseContains to elementExists which is the right way to check.
I also confirmed each assertion is still acting on the same element.
Comment #16
liam morlandThanks very much!
Comment #17
liam morlandComment #21
nicxvan commented