Problem/Motivation

These two hooks are closely related.

Furthermore, they're badly-named -- hook_menu_local_tasks_alter() follows the same pattern as the plugin info alter hooks for other menu plugins, but it is NOT the plugin info alter hook!

A @see link between the two would help with this.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3462098

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joachim created an issue. See original summary.

joachim’s picture

Version: 11.0.x-dev » 11.x-dev

Prem Suthar made their first commit to this issue’s fork.

prem suthar’s picture

Status: Active » Needs review

@joachim I have added the Changes As per my Understanding , Please Review It and give The suggestions .

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new681 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

joachim’s picture

Status: Needs work » Reviewed & tested by the community

Looks good, not sure why the bot is unhappy as the MR pipeline has passed.

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new681 bytes

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

Status: Needs work » Needs review
Issue tags: +no-needs-review-bot

Failing commit code check locally only. PHPStan doesn't like it when there is only one file and it *.api.php.

joachim’s picture

Status: Needs review » Reviewed & tested by the community

> PHPStan doesn't like it when there is only one file and it *.api.php.

Urgh! is there an issue for that problem?

  • nod_ committed a3075fda on 10.3.x
    Issue #3462098 by Prem Suthar, joachim, quietone: hook_local_tasks_alter...

  • nod_ committed 1009866a on 10.4.x
    Issue #3462098 by Prem Suthar, joachim, quietone: hook_local_tasks_alter...
nod_’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed e8cafee5ae to 11.x and 58f4b99d0f to 11.0.x and 1009866a33 to 10.4.x and a3075fda43 to 10.3.x. Thanks!

  • nod_ committed 58f4b99d on 11.0.x
    Issue #3462098 by Prem Suthar, joachim, quietone: hook_local_tasks_alter...

  • nod_ committed e8cafee5 on 11.x
    Issue #3462098 by Prem Suthar, joachim, quietone: hook_local_tasks_alter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.