Closed (fixed)
Project:
Drupal core
Version:
10.3.x-dev
Component:
documentation
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Jul 2024 at 14:12 UTC
Updated:
9 Aug 2024 at 12:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
joachim commentedComment #5
prem suthar commented@joachim I have added the Changes As per my Understanding , Please Review It and give The suggestions .
Comment #6
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #7
joachim commentedLooks good, not sure why the bot is unhappy as the MR pipeline has passed.
Comment #8
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #9
quietone commentedFailing commit code check locally only. PHPStan doesn't like it when there is only one file and it *.api.php.
Comment #10
joachim commented> PHPStan doesn't like it when there is only one file and it *.api.php.
Urgh! is there an issue for that problem?
Comment #14
nod_Committed and pushed e8cafee5ae to 11.x and 58f4b99d0f to 11.0.x and 1009866a33 to 10.4.x and a3075fda43 to 10.3.x. Thanks!