Problem/Motivation
Following #3420972: Add testing wtih SQLite 3.45 there are two flavours of PHP container for CI, php-8.3-apache with SQLite 3.40 and php-8.3-ubuntu-apache with SQLite 3.45. At present only the SQLite tests use the later container.
Some build tests require SQLite even when run on other database drivers and have code that checks the version:
protected function setUp(): void {
$sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];
if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {
$this->markTestSkipped();
}
However, this means that these tests are effectively skipped on MySQL/Postgres because their PHP containers run SQLite 3.40 but in 11.x SQLITE_MINIMUM_VERSION is set to 3.45. In turn this resulted in #3458975: GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite not being noticed for several weeks because most of the time we don't explicitly run tests on SQLite.
Steps to reproduce
Proposed resolution
Use the -ubuntu variant of all containers *except* in 10.x when we explicitly want to test on an older version of SQLite.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3461006
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3461006-use-ubuntu-images
changes, plain diff MR !8752
Comments
Comment #2
longwaveComment #4
longwaveComment #5
longwaveGenerateThemeTest should fail here even on mysql because of #3458975: GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite
Comment #6
longwaveFailed as expected; postponing on that issue, although we could merge the two.
Comment #7
andypostThere's some repeatable failure for mysql as well, maybe the issue in transition out of mysql_safe... I will check deeper this weekend
Comment #8
andypostblocker is in
Comment #9
andypostSomething wrong with the "Test-only" job but it looks unrelated
Also nightwatch still fails https://git.drupalcode.org/issue/drupal-3461006/-/jobs/2268701
Comment #12
catchCommitted/pushed to 11.x and cherry-picked to 11.0.x, thanks!