Problem/Motivation

Following #3420972: Add testing wtih SQLite 3.45 there are two flavours of PHP container for CI, php-8.3-apache with SQLite 3.40 and php-8.3-ubuntu-apache with SQLite 3.45. At present only the SQLite tests use the later container.

Some build tests require SQLite even when run on other database drivers and have code that checks the version:

  protected function setUp(): void {
    $sqlite = (new \PDO('sqlite::memory:'))->query('select sqlite_version()')->fetch()[0];
    if (version_compare($sqlite, Tasks::SQLITE_MINIMUM_VERSION) < 0) {
      $this->markTestSkipped();
    }

However, this means that these tests are effectively skipped on MySQL/Postgres because their PHP containers run SQLite 3.40 but in 11.x SQLITE_MINIMUM_VERSION is set to 3.45. In turn this resulted in #3458975: GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite not being noticed for several weeks because most of the time we don't explicitly run tests on SQLite.

Steps to reproduce

Proposed resolution

Use the -ubuntu variant of all containers *except* in 10.x when we explicitly want to test on an older version of SQLite.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3461006

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
longwave’s picture

longwave’s picture

Status: Needs review » Postponed

Failed as expected; postponing on that issue, although we could merge the two.

andypost’s picture

There's some repeatable failure for mysql as well, maybe the issue in transition out of mysql_safe... I will check deeper this weekend

andypost’s picture

Status: Postponed » Needs review

blocker is in

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Something wrong with the "Test-only" job but it looks unrelated

Also nightwatch still fails https://git.drupalcode.org/issue/drupal-3461006/-/jobs/2268701

  • catch committed 557d779f on 11.0.x
    Issue #3461006 by longwave, andypost: Use Ubuntu images in all CI...

  • catch committed cfdd150c on 11.x
    Issue #3461006 by longwave, andypost: Use Ubuntu images in all CI...
catch’s picture

Version: 11.x-dev » 11.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.