[2.0.0-alpha3] Little cleanups

1. run prettier on YML files >> DONE
2. run twig linter on Twig files >> DONE
3. update module descriptions in info files >> DONE
4. check if all phpunit tests are running
5. fix some PHPCS or PHPMD feedbacks

Can you do the rest?

vendor/bin/phpcs --standard=Drupal --extensions=php,module docroot/modules/custom/ui_patterns
vendor/bin/phpcs --standard=PHPCompatibility --extensions=php,module --runtime-set testVersion 8.3 docroot/modules/custom/ui_patterns
vendor/bin/phpmd docroot/modules/custom/ui_patterns text codesize
vendor/bin/phpmd docroot/modules/custom/ui_patterns text unusedcode
vendor/bin/phpmd docroot/modules/custom/ui_patterns text design
vendor/bin/drupal-check docroot/modules/custom/ui_patterns

Especially PHPMD unused local variables:

modules/ui_patterns_blocks/src/Plugin/Derivative/EntityComponentBlock.php:17                         UnusedLocalVariable    Avoid unused local variables such as '$component_id'.
modules/ui_patterns_devel/tests/src/Unit/TwigValidatorRulePluginTest.php:282                         UnusedPrivateMethod    Avoid unused private methods such as 'processNodeWithPrivateFunc'.
modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php:292  UnusedLocalVariable    Avoid unused local variables such as '$prop_id'.
modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php:299  UnusedLocalVariable    Avoid unused local variables such as '$slots_id'.
modules/ui_patterns_field_formatters/src/Plugin/Field/FieldFormatter/ComponentFormatterBase.php:303  UnusedLocalVariable    Avoid unused local variables such as '$source_id'.
modules/ui_patterns_views/src/Plugin/views/row/ComponentRow.php:98                                   UnusedFormalParameter  Avoid unused parameters such as '$form'.
modules/ui_patterns_views/src/Plugin/views/row/ComponentRow.php:98                                   UnusedFormalParameter  Avoid unused parameters such as '$form_state'.
modules/ui_patterns_views/src/Plugin/views/style/ComponentStyle.php:108                              UnusedLocalVariable    Avoid unused local variables such as '$delta_group'.
modules/ui_patterns_views/src/Plugin/views/style/ComponentStyle.php:131                              UnusedLocalVariable    Avoid unused local variables such as '$group_fields'.
modules/ui_patterns_views/src/Plugin/views/style/ComponentStyle.php:140                              UnusedLocalVariable    Avoid unused local variables such as '$delta_group'.
modules/ui_patterns_views/src/Plugin/views/style/ComponentStyle.php:208                              UnusedFormalParameter  Avoid unused parameters such as '$form_state'.

Mosty of them are caused by the combination between key => value loops and reference:

foreach ($form['grouping'] as $delta_group => &$group) {

thanks.

Why do we have empty methods in src/Plugin/Derivative/EntityFieldSourceDeriverBase.php :

  /**
   * Get derivative definitions per entity bundle field.
   *
   * @param string $entity_type_id
   *   The entity type id.
   * @param string $bundle
   *   The bundle.
   * @param string $field_name
   *   The field name.
   * @param array $base_plugin_derivative
   *   The base plugin derivative.
   */
  protected function getDerivativeDefinitionsForEntityBundleField(string $entity_type_id, string $bundle, string $field_name, array $base_plugin_derivative): void {

  }

  /**
   * Get derivative definitions per entity field storage.
   *
   * @param string $entity_type_id
   *   The entity type id.
   * @param string $field_name
   *   The field name.
   * @param array $base_plugin_derivative
   *   The base plugin derivative.
   */
  protected function getDerivativeDefinitionsForEntityStorageField(string $entity_type_id, string $field_name, array $base_plugin_derivative): void {

  }

  /**
   * Get derivative definitions per entity field storage.
   *
   * @param string $entity_type_id
   *   The entity type id.
   * @param string $field_name
   *   The field name.
   * @param string $property
   *   The property.
   * @param array $base_plugin_derivative
   *   The base plugin derivative.
   */
  protected function getDerivativeDefinitionsForEntityStorageFieldProperty(string $entity_type_id, string $field_name, string $property, array $base_plugin_derivative): void {

  }
 

Thanks, i take the ticket for some linting.

Some PHPSTAN work to do before merge.