Problem/Motivation

For Drupal 10.3 compatibility, CKEditor Model needs to be replaced with ViewModel.

Steps to reproduce

Load a page that includes the Augmentor widget in CKEditor. Note the error message on the browser console, "TypeError: e.Model is not a constructor".

Proposed resolution

Replace CKEditor Model with ViewModel.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork augmentor-3457128

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

Liam Morland opened merge request !31

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review

The merge request has a fix, though this may cause problems with backward compatibility. This is a similar issue to #3452570: CKEditor 5 41.3.1 (Drupal 10.3 beta) breaking change; we may need to do something like the fix in this issue to resolve the backward compatibility problem.

keiserjb’s picture

keiserjb commented

Mine says "TypeError: t.Model is not a constructor". I think the patch resolved it.

eleonel’s picture

eleonel
he/him
Primary language Spanish
Location Itoshima 🇯🇵
commented
Status: Needs review » Fixed

I created a new release branch 1.2.x to avoid breaking existing installations.

  • eleonel committed be7f620d on 1.2.x authored by liam morland 
    Issue #3457128 by liam morland, keiserjb: Replace CKEditor Model with...
eleonel’s picture

eleonel
he/him
Primary language Spanish
Location Itoshima 🇯🇵
commented
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Version: 1.1.x-dev » 1.2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.