Problem/Motivation

Drupal 10.3.0 stable was released on: 20 Jun 2024 by: catch
https://www.drupal.org/project/drupal/releases/10.3.0

Thanks, to the Drupal Core release team
  • Drupal 11.0.0-rc1 about to be released

The SDC experimental module is now stable and merged into core

Proposed resolution

  • Change core_version_requirement to ^10.3 || ^11 in the cl_server.info.yml file.
  • Remove drupal:sdc from the cl_server.info.yml file.

Remaining tasks

  • File an issue
  • MR/Patch
  • Test
  • Review

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 cl_server--2024-06-25--3456661-9--mr-32.patch3.62 KBrajab natshah
#4 cl_server--2024-06-24--3456661--mr-32.patch461 bytesrajab natshah

Issue fork cl_server-3456661

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rajab Natshah created an issue. See original summary.

Rajab Natshah opened merge request !32

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: rajab natshah » Unassigned
Status: Active » Needs review
rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new cl_server--2024-06-24--3456661--mr-32.patch461 bytes

Attached a static patch file for cl_server 2024-06-24 MR 32
to be used with composer patches

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Needs work

We'll need some code updates too for the namespace changes:


TypeError: Drupal\cl_editorial\NoThemeComponentManager::__construct(): Argument #1 ($pluginManager) must be of type Drupal\sdc\ComponentPluginManager, Drupal\Core\Theme\ComponentPluginManager given, called in /var/www/html/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 261 in Drupal\cl_editorial\NoThemeComponentManager->__construct() (line 23 of modules/contrib/cl_editorial/src/NoThemeComponentManager.php).

Drupal\Component\DependencyInjection\Container->createService(Array, 'Drupal\cl_editorial\NoThemeComponentManager') (Line: 179)
Drupal\Component\DependencyInjection\Container->get('Drupal\cl_editorial\NoThemeComponentManager')
array_map(Array, Array) (Line: 39)
Drupal\sdc_block\Plugin\Derivative\ComponentBlockDeriver::create(Object, 'sdc_component_block') (Line: 25)
Drupal\Core\Plugin\Discovery\ContainerDerivativeDiscoveryDecorator->getDeriver('sdc_component_block', Array) (Line: 99)
Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDerivatives(Array) (Line: 87)
Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDefinitions() (Line: 337)
Drupal\Core\Plugin\DefaultPluginManager->findDefinitions() (Line: 213)
Drupal\Core\Plugin\DefaultPluginManager->getDefinitions() (Line: 22)
Drupal\Core\Plugin\DefaultPluginManager->getDefinition('local_actions_block') (Line: 16)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('local_actions_block', Array) (Line: 76)
Drupal\Component\Plugin\PluginManagerBase->createInstance('local_actions_block', Array) (Line: 62)
Drupal\Core\Plugin\DefaultSingleLazyPluginCollection->initializePlugin('local_actions_block') (Line: 57)
Drupal\block\BlockPluginCollection->initializePlugin('local_actions_block') (Line: 80)
Drupal\Component\Plugin\LazyPluginCollection->get('local_actions_block') (Line: 45)
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review

Ignore #6. That stack trace is from the related module: cl_editorial

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

The PR fixes things. LGTM.

rajab natshah’s picture

rajab natshah
he/him
commented
StatusFileSize
new cl_server--2024-06-25--3456661-9--mr-32.patch3.62 KB

Thanks, Lucas, for having the right changes.

Attached a static patch file for cl_server 2024-06-25 MR 32
to be used with composer patches
After d4f9ada0 - fix imports by Lucas

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Is anything still blocking release ? Can I help ?