Problem/Motivation

A user who has permission edit terms in VOCABULARY is unable to edit terms if they do not also have permission administer taxonomy. This is because of a bug in TaxonomyManagerAccessCheck::access().

Proposed resolution

Allow TaxonomyManagerAccessCheck::access() to get the vocabulary from the taxonomy_term parameter and act on the taxonomy_manager.taxonomy_term.edit route.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 taxonomy_manager-unable_to_edit-3449448-4.patch1.29 KBliam morland

Issue fork taxonomy_manager-3449448

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

Liam Morland opened merge request !38

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new taxonomy_manager-unable_to_edit-3449448-4.patch1.29 KB

This patch is the current state of the merge request.

laura.gates’s picture

laura.gates
She/Her
commented
Status: Needs review » Reviewed & tested by the community

My site is configured similarly where we allow users to edit taxonomy terms but not manage the vocabularies. The patch applied for me in 2.0.11 of this module. I made a test account with the edit taxonomy terms permission and not the administer taxonomy permission. I was able to successfully create new terms and edit existing terms in existing vocabularies.

Patch is successful. Thanks for noticing and fixing Liam!

VladimirAus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you! 🧁

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.