Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

-- snip auto text --

Also, fixed a conflict with symfony/serializer v7, and phpcs failures that happened to be introduced around this time.

D11 test incompatibility

Gitlab-CI still fails installing dev dependencies: the video_embed_field and media_entity_twitter module cannot be installed on D11.

media_entity_twitter could get a D11 release. Once video_embed_field is the only module that is holding up installation/testing, IMHO we should just get rid of the tests for the video processor, so that it isn't a dev depencency anymore, and the other tests can run.

The video processor can stay in the code, untested. It won't change anymore / noone on D10+ is likely to be using it.

CommentFileSizeAuthor
#5 custom_elements.2.x-dev.rector.patch3.51 KBproject update bot
#5 interdiff-last-bot.6942157.txt1.28 KBproject update bot
#4 custom_elements.2.x-dev.rector.patch1.62 KBproject update bot
#4 interdiff-last-bot.6938710.txt479 bytesproject update bot
#2 custom_elements.2.x-dev.upgrade_status.post_rector.txt6.66 KBproject update bot
#2 custom_elements.2.x-dev.rector.patch1008 bytesproject update bot

Issue fork custom_elements-3448656

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new custom_elements.2.x-dev.rector.patch1008 bytes
new custom_elements.2.x-dev.upgrade_status.post_rector.txt6.66 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-177898

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.1
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !67

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6938710.txt479 bytes
new custom_elements.2.x-dev.rector.patch1.62 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-185727

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.1
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.1
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6942157.txt1.28 KB
new custom_elements.2.x-dev.rector.patch3.51 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188138

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.2

fago made their first commit to this issue’s fork.

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Automated Drupal 11 compatibility fixes for custom_elements » Drupal 11 compatibility fixes for custom_elements 2.x
Issue summary: View changes
Status: Needs review » Needs work

merging this, let's wait for a positive test report before closing it though

fago’s picture

fago
Primary language German
Location Vienna
commented
Assigned: Unassigned » useernamee
useernamee’s picture

useernamee commented

3.x of custom_elements is not Drupal 11 compatible: #3470347: Drupal 11 compatibility fixes for custom_elements 3.x

There is also a conflict with the symfony/serializer https://github.com/symfony/symfony/blob/7.1/src/Symfony/Component/Serial...

Fatal error: Declaration of Drupal\custom_elements\CustomElementNormalizer::supportsNormalization($data, $format = null): bool must be compatible with Symfony\Component\Serializer\Normalizer\NormalizerInterface::supportsNormalization(mixed $data, ?string $format = null, array $context = []): bool in /var/www/html/web/modules/contrib/custom_elements/src/CustomElementNormalizer.php on line 27

useernamee opened merge request !97

useernamee’s picture

useernamee commented
Assigned: useernamee » fago
Status: Needs work » Needs review
useernamee’s picture

useernamee commented
Assigned: fago » roderik

reRolled the branch and fix phpcs issue (only in the changed file)

roderik made their first commit to this issue’s fork.

  • roderik committed a4200a56 on 8.x-2.x authored by useernamee 
    Issue #3448656 by Project Update Bot, fago: Drupal 11 compatibility...
roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Assigned: roderik » Unassigned
Issue summary: View changes
Status: Needs review » Fixed
Issue tags: +Barcelona2024

Thanks! Merged.

The recent phpcs failures are all introduced because of the update to coder 8.3.25. Fixing them too.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.