Problem/motivation

As "url_embed" overrides "filter_settings.*" with type "mapping", whereas the original type is "sequence", in "url_embed.schema.yml" it breaks other filter_settings.

Steps to reproduce

  1. With URL Embed enabled go to /admin/config/content/formats and edit or create a format
  2. Try to add media embed for CKEditor 5, and save.
  3. A long list of errors like "'allowed_media_types' is not a supported key." will occur, and the format can not be save.

Proposed resolution

Remove the "filter_settings.*" override in "url_embed.schema.yml" and replace "filter_settings.url_embed_convert_links" type "sequence" with "filter" as that seems to be the correct way to declare filter_settings.
I've added a patch file to this issue.

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
CommentFileSizeAuthor
filter-settings-override-type-invalid.patch512 bytesflemming.fridthjof

Issue fork url_embed-3448488

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

flemming.fridthjof created an issue. See original summary.

mark_fullmer made their first commit to this issue’s fork.

mark_fullmer opened merge request !17

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Active » Reviewed & tested by the community

Thanks for the catch! This makes sense and comports with the syntax used in Drupal core & elsewhere for filter format settings.

  • mark_fullmer committed ecc1f574 on 3.x 
    Issue #3448488 by flemming.fridthjof: Filter settings override in...
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Reviewed & tested by the community » Fixed

Tests are failing as expected: "current major" has an issue with Twitter output, and "next major" does not have a compatible version of drupal/embed to use. Proceeding to merge, as 3.x is in alpha currently, anyway.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.