Problem/Motivation

https://blog.jqueryui.com/2024/05/jquery-ui-1-14-0-beta-1-released/

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3447472

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Priority: Normal » Major
Status: Active » Needs review
Issue tags: +beta target
quietone’s picture

Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

Took a minute before I remembered how to update jquery but I got there. I did this locally and the resulting changes matche the changes in the MR. And it applies to 110.0.x as well.

quietone’s picture

  • alexpott committed 55c348aa on 11.0.x
    Issue #3447472 by larowlan, quietone: Update to jquery UI 1.14.0 beta
    
    (...

  • alexpott committed 539c50a2 on 11.x
    Issue #3447472 by larowlan, quietone: Update to jquery UI 1.14.0 beta
    
alexpott’s picture

Version: 11.x-dev » 11.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 539c50a257 to 11.x and 55c348aaaf to 11.0.x. Thanks!

I can confirm that the build does not result in any changed files.

catch’s picture

Do we want to consider backporting this to 10.4? It looks like if we re-enable compat mode, it might be a small enough change that this would be reasonable to do, but I didn't look into enough to be confident yet.

m_gol’s picture

If you can, definitely consider backporting this! The full changelog for the beta is https://jqueryui.com/changelog/1.14.0-beta.1/. Most breaking changes are dropping support for some older browser / jQuery releases, the back compat flag can be reversed. Beyond that, changes are pretty minor, even the included jQuery Color major update is pretty minor wrt. breaking changes: https://github.com/jquery/jquery-ui/commit/68fda5beb2035faa1e30f26722417...

catch’s picture

Version: 11.0.x-dev » 10.4.x-dev
Status: Fixed » Patch (to be ported)

Re-opening for the backport discussion.

xjm’s picture

I'm unsure about backporting this. We did discuss the D10 support timeline (for jQuery 1.13 support implications) with @m_gol and they seemed comfortable with it (thanks @m_gol!)

Also, if we were to backport it, it should possibly be done in 10.3 for parity with 11.0... except that dependencies don't usually have parity, so that is more of a "should-have" I think. 10.4 is also going to be a maintenance minor (our first), so changes going into it should restrict disruption. OTOH keeping the maintenance minors' dependencies in sync with the D11 series is part of what they're for, so if the changes are more minor-ish than major-ish from a semver perspective, maybe we could backport it with the compact mode change and a detailed release note about jQuery 1.14.

One thing we need to pay attention to is if jQuery 1.14's dropped older jQuery version support is compatible with our release cycle and how that would affect maintenance releases (though the info is useful for D11 as well). I.e., How behind are we on jQuery minors? Frequently, the security team has to write emergency bridge code to update to a new jQuery version and/or fork the fix into core when we're on the previous jQuery minor and a JQuery minor update is too disruptive for a security window. So we should check the currently supported versions for each branch, and also go back historically and look at the latency between our jQuery minor version bumps each time.

Tagging for FFM and RM review on whether to backport.

catch’s picture

OTOH keeping the maintenance minors' dependencies in sync with the D11 series is part of what they're for, so if the changes are more minor-ish than major-ish from a semver perspective, maybe we could backport it with the compact mode change and a detailed release note about jQuery 1.14.

Yeah this is what I was thinking.

I.e., How behind are we on jQuery minors?

10.1.x is on jQuery 3.7.0
10.2.x is on jQuery 3.7.1
10.3.x is on jQuery 3.7.1

3.7.1 was released in August 2023 https://blog.jquery.com/2023/08/28/jquery-3-7-1-released-reliable-table-...

10.2.0 was released in December 2023. So at least last time, we successfully got onto the next jQuery minor release as soon as possible (i.e. our next minor release window).

damienmckenna’s picture

10.3.0 is out already, does that mean it's too late to backport this issue and it should go back to being "fixed"?

catch’s picture

It's too late to backport to 10.3.x but we could still consider backporting to 10.4.x.

xjm credited nod_.

xjm’s picture

Discussed with @mgol, @catch, and @nod_. Based on the discussion, I think we should indeed also backport this to 10.4. We'll need to modify the release note a little to mention that there are a handful of small BC breaks in the upgrade guide that may require updates to custom code, but overall it's fairly non-disruptive for us and it fits with the objectives for maintenance minors of keeping up with secure dependency versions.

nod_’s picture

Status: Patch (to be ported) » Fixed

update is happening in the other issue: #3449875: Update to jQuery UI 1.14.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xjm’s picture

Failed to credit myself in #17.