Problem/Motivation

It seems various Sentry code cannot determine when a transaction is not sampled, because unsampled transactions are not set on the hub.

Steps to reproduce

Look at sentry meta tags on a page when the transaction was not sampled.

Proposed resolution

Various code runs when a span is present on the hub. Instead, that code could run if a span is both present and sampled.

Remaining tasks

Backport to 5.x, 4.x and 3.x

User interface changes

API changes

Data model changes

Issue fork raven-3447361

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mfb created an issue. See original summary.

  • mfb committed dc8ee55b on set-transaction 
    Issue #3447361 by mfb: Always set transaction

  • mfb committed 3e1b2751 on 6.x 
    Issue #3447361 by mfb: Always set transaction
mfb’s picture

mfb
they or he
commented
Version: 6.x-dev » 5.x-dev
Status: Active » Patch (to be ported)
mfb’s picture

mfb
they or he
commented

Verified that this fix is correct in https://github.com/getsentry/sentry-laravel/issues/894

mfb opened merge request !40

  • mfb committed 92551814 on 5.x 
    Issue #3447361 by mfb: Always set transaction

mfb opened merge request !41

  • mfb committed d5996a4a on 4.x 
    Issue #3447361 by mfb: Always set transaction

mfb opened merge request !42

  • mfb committed 1f3c9b4e on 3.x 
    Issue #3447361 by mfb: Always set transaction
mfb’s picture

mfb
they or he
commented
Status: Patch (to be ported) » Fixed
mfb’s picture

mfb
they or he
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.