Problem/Motivation

We'd like to get this module working with Funnelback 16 in order to support users on Squiz DXP.

Steps to reproduce

N/A

Proposed resolution

Easiest way would be to implement a version toggle in the Funnelback module config and modify the query and results handling accordingly. It might be possible to identify the version automatically based on the results package but I'm cautious about trying to do too much just yet.

Remaining tasks

  1. Integrate Funnelback 16
  2. Backwards compatibility
  3. Tests
  4. Update default Twig templates (might leave this for a future beta)

User interface changes

None.

API changes

Templates now have a `list_metadata` property that does the same thing that the Funnelback 15-compatible `metadata` does. Currently this is optional, but users should opt for `list_metadata` going forward. We might enforce this later on. Plus, working with the list is easier than manipulating entire strings.

Data model changes

Search results that come back from Funnelback now have a `listMetadata` property that have a list-formatted version of the `metaData` property. These results are populated directly from Funnelback 16 search results, and for backward compatbility, are interpolated from Funnelback 15's pipe-separated `metaData`.

Facets are similarly interpolated from the Funnelback 16 `allValues` property.

Issue fork funnelback-3447253

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

geoffreyr created an issue. See original summary.

geoffreyr’s picture

Adding #3441681 as related; I'd like to get this implemented so we can test our changes.

geoffreyr’s picture

We've finally got this implementation into PRODUCTION, so I might look at finishing off the tests so it's ready for review.

geoffreyr’s picture

Assigned: geoffreyr » Unassigned
Issue summary: View changes
Status: Active » Needs review

That took a little while, but I finally got a merge request going with a PHPUnit test for the FB16 data. This code is already running in our PROD environment but if anyone wants to review by all means go for it. I might line up a new beta release featuring this update -- the good news is that it should be backwards-compatible.

geoffreyr’s picture

Status: Needs review » Fixed

Targetting to 2.0.0-beta4.

  • geoffreyr committed 51610ebb on 2.x
    Issue #3447253 by geoffreyr: Funnelback 16 support
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.