Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3443487-nr-bot.txt3.74 KBneeds-review-queue-bot

Issue fork drupal-3443487

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Assigned: Unassigned » smustgrave

smustgrave opened merge request !7728

smustgrave’s picture

smustgrave commented
Status: Active » Needs review

All green.

quietone’s picture

quietone commented
Status: Needs review » Needs work

I reviewed all but FieldTypePlug‎inManager.php, due to conflicts,‎ and the changes look correct. Setting to NW for a rebase

adwivedi008 made their first commit to this issue’s fork.

adwivedi008’s picture

adwivedi008 commented

Rebased the branch with 11.x
Please review if any other changes are required.
Moving the issue to Needs Review

adwivedi008’s picture

adwivedi008 commented
Status: Needs work » Needs review
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3443487-nr-bot.txt3.74 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

@adwivedi008 please test what you upload. Would of noticed the variables weren't right and caused many failures.

Fixed

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs review » Needs work
smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Thanks! Addressed feedback.

smustgrave’s picture

smustgrave commented

Oops forgot the doc update too.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
Status: Needs review » Reviewed & tested by the community

The changes look good, Thanks!

  • catch committed ddf4ed62 on 11.x 
    Issue #3443487 by smustgrave: Remove deprecated code from lib/...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

  • catch committed ddf4ed62 on 11.0.x 
    Issue #3443487 by smustgrave: Remove deprecated code from lib/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.