Coder 8.3.24 has just been released. This has a new standard for multi-line function definitions #3440075: Add rule for multi-line function declarations

This was also discussed in the Coding Standards issue #3295249: Allow multi-line function declarations

Issue fork scheduler-3442310

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 changed the visibility of the branch 3049585-drupal-testing to hidden.

jonathan1055 opened merge request !133

  • jonathan1055 committed e9a6e5cc on 2.x 
    Issue #3442310 by jonathan1055: Fix new PHPCS standard for multi-line...
jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed

Nice easy fix. PHPCBF also has automatic fixing too.

  • jonathan1055 committed 69182483 on 8.x-1.x 
    Issue #3442310 by jonathan1055: PHPCS standard for multi-line function...

  • jonathan1055 committed 1fc564ac on 2.x 
    Issue #3442310 by jonathan1055: Remove multiline function definition...

jonathan1055 opened merge request !137

jonathan1055’s picture

jonathan1055 commented

The trailing comma is incompatible with PHPUnit 9.6.19 in Drupal 9.5 PHP 7.4. Therefore removed the comma and added

// phpcs:ignore Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma

  • jonathan1055 committed e8334bea on 8.x-1.x 
    Issue #3442310 by jonathan1055: Remove trailing comma for backwards...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.