Linting Issues

Gitlab was recently installed and there are multiple linting issues that need to be resolved.

Version 5.0 View Issues here

Issue fork bootstrap_paragraphs-3439732

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kerrymick created an issue. See original summary.

stockfoot’s picture

stockfoot commented
Assigned: Unassigned » stockfoot

Assigning this to myself to begin work on the issue, thanks!

Stockfoot opened merge request !31

stockfoot’s picture

stockfoot commented
Assigned: stockfoot » Unassigned
Status: Active » Needs review

I have completed fixing all the linting issues that were discovered by adding the gitlab-ci.yml file to the module.
I have also updated the variables in the gitlab-ci.yml file.

Moving to "Needs review" status and unassigning myself from the issue, thanks!

thejimbirch’s picture

thejimbirch commented
Title: Fix Linting Issues » Fix Linting Issues - 5.0.x-dev
twills’s picture

twills commented
Status: Needs review » Needs work

Lint issues seem to be resolved, but cspell is still throwing a warning.

stockfoot’s picture

stockfoot commented

If you look at the cspell error, it flags 'Grey' and 'grey' repeatedly.
If you look at the variables section of the gitliab-ci.yml you can see the list of words that should be ignored.
Both 'Grey' and 'grey' are on the list but the linting continues to flag it.
I am unsure of why this is happening or exactly how to fix it

thejimbirch’s picture

thejimbirch commented
Assigned: Unassigned » thejimbirch

Great deduction!

Looks like someone in Drupal core is very opinionated that it should be gray not grey as it is added to the cspell flagWords

https://git.drupalcode.org/project/drupal/-/blob/11.x/core/.cspell.json?...

The cspell documentation for forbidden words states we can override that using

{
  "ignoreWords": ["forbiddenWord"]
}

I will try to add that now.

thejimbirch’s picture

thejimbirch commented
Status: Needs work » Fixed

That worked. There are still some minor issue that have been introduced, but we can address in follow ups.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.