Problem/Motivation

As part of the D9/10 changes, noticed the following via upgrade_status

 [notice] Processing /var/www/html/web/modules/contrib/recurly_roles-3436806.

================================================================================
Recurly Roles, --
Scanned on Tue, 04/09/2024 - 15:32

FILE: web/modules/contrib/recurly_roles-3436806/recurly_roles.module

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      99   Call to deprecated function user_role_names(). Deprecated in
                    drupal:10.2.0 and is removed from drupal:11.0.0. Use        
                    Drupal\user\Entity\Role::loadMultiple() and, if necessary,  
                    an inline implementation instead.                           
--------------------------------------------------------------------------------

FILE: web/modules/contrib/recurly_roles-3436806/recurly_roles.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9 || ^10 is not         
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

It would be good to resolve these issues for D11.

CommentFileSizeAuthor
#12 recurly roles.png25.23 KBkalash-j

Issue fork recurly_roles-3439684

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aaron.ferris created an issue. See original summary.

shivam_tiwari made their first commit to this issue’s fork.

shivam_tiwari’s picture

shivam_tiwari commented
Assigned: Unassigned » shivam_tiwari

sarwan_verma made their first commit to this issue’s fork.

sarwan_verma opened merge request !5

sarwan_verma’s picture

sarwan_verma commented
Assigned: shivam_tiwari » Unassigned
Status: Active » Needs review

Hi @aaron.ferris,
fix the issue and created MR. please review it once.

aaron.ferris’s picture

aaron.ferris commented
Status: Needs review » Needs work

Thanks for the MR, raised a few points.

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs work » Needs review

@aaron.ferris Please verify changes and let us know if any issue.

aaron.ferris’s picture

aaron.ferris commented

Thanks, this still needs attention I think - core/jquery.once doesn't exist in Drupal 10+

aaron.ferris’s picture

aaron.ferris commented
Status: Needs review » Needs work
shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs work » Needs review

@aaron.ferris Yes. I missed it. Please check now.

kalash-j’s picture

kalash-j commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new recurly roles.png25.23 KB

I have tested it on my local , did not found any issue
RTBC+1

aaron.ferris’s picture

aaron.ferris commented

Thanks for addressing the code review comments, and thanks for working on this all.

Merged, ill create a new release shortly to include D11.

aaron.ferris’s picture

aaron.ferris commented
aaron.ferris’s picture

aaron.ferris commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.