Problem/Motivation

New option "Disable front page redirects for the administrator role." should be hidden unless "Authenticated users" checkbox is enabled. Otherwise this makes no sense and is confusing.

Furthermore it should be reset to FALSE on form save, if "Authenticated users" checkbox is NOT enabled so that this doesn't cause unexpected results.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork front-3438841

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

nidhi27’s picture

nidhi27
She/Her
commented
Assigned: Unassigned » nidhi27

nidhi27 changed the visibility of the branch 3438841-make-disable-front to hidden.

nidhi27 opened merge request !13

nidhi27’s picture

nidhi27
She/Her
commented
Assigned: nidhi27 » Unassigned
Status: Active » Needs review

I have created #MR13 to hide the checkbox based on the condition.
Kindly review it and let me know if any changes are needed.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Thanks @nidhi27 I left a comment. Please fix it and test yourself.

nidhi27’s picture

nidhi27
She/Her
commented

Hi @Anybody,

Please check my comment and provide your input.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +Needs tests

Could you eventually add test coverage for these options? (not the states api part)?

Then we'd be safe it works as expected now and in the future!

TL;DR: If hidden, the checkbox should never be "TRUE" after save.

nidhi27’s picture

nidhi27
She/Her
commented

Hi @Anybody,

I think It would be great if we add all the test cases together in https://www.drupal.org/project/front/issues/3438834. Let me know what do you suggest.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Yeah that would also be fine.

nidhi27’s picture

nidhi27
She/Her
commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

Great! Ready for sign-off by codemaster @Grevil! :)

nidhi27’s picture

nidhi27
She/Her
commented
Assigned: grevil » nidhi27
nidhi27’s picture

nidhi27
She/Her
commented
Assigned: nidhi27 » Unassigned

Hii,

I have added the test case for this functionality. Let me know if any changes are needed.
Thanks!

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Ok, this should be it, let's wait for the test output. Thanks for your work @nidhi27!

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Test is green again.

  • grevil committed 74321599 on 10.x authored by nidhi27 
    Issue #3438841 by nidhi27, grevil, anybody: Make "Disable front page...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.