Problem/Motivation

Switch from DrupalCI testing to Drupal Gitlab templates.

Steps to reproduce

Proposed resolution

Remaining tasks

  • Fix issues reported by cspell CI job
  • Fix issues reported by eslint CI job
  • Fix issues reported by stylelint CI job
  • Remove all DrupalCI automated tests, when issue is fixed

User interface changes

API changes

Data model changes

Issue fork bootstrap_paragraphs-3437111

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

IT-Cru created an issue. See original summary.

IT-Cru changed the visibility of the branch 3437111-add-drupal-gilab to hidden.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Title: Add Drupal Gilab CI templates » Add Drupal Gitlab CI templates

IT-Cru changed the visibility of the branch 3437111-add-drupal-gilab to active.

IT-Cru opened merge request !25

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Issue summary: View changes
it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Assigned: it-cru » Unassigned
Priority: Normal » Major

@kerrymick @thejimbirch: I've raised this to major because PHPStan found a possible issue in update path. See my changes in bp_card.install file. Maybe these changes should be cherry picked for a 5.0.1 hotfix release.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Status: Active » Needs review
thejimbirch’s picture

thejimbirch commented

Thanks IT-Cru!

it-cru’s picture

it-cru
Primary language English
Location Munich
commented

@thejimbirch Does it also make sense to add Gitlab CI templates to 8.x-2.x branch because of current usages?

thejimbirch’s picture

thejimbirch commented

Yeah, that is a great idea. We plan on supporting that minimally.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Related issues: +#3437219: Add Drupal Gitlab CI templates

kerrymick’s picture

kerrymick commented
Status: Needs review » Fixed

Fixes merged.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented

@kerrymick: Should current state of 5.0.x be tagged as hotfix 5.0.1 to avoid issues for people who tries to upgrade from 8.x-2.x to 5.0.x because of this issue detected by PHPStan CI job (mentioned in #7?

I think this would be a good idea to avoid popup of follow up issues with broken upgrades.

thejimbirch’s picture

thejimbirch commented

Thank @IT-Cru. 5.0.1 released.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.