Problem/Motivation

Follow-up to #3354099: Add functional test that proves there is reasonable UX whenever Composer Stager operations have a hard failure to solve the problem in automatic_updates_extensions

Steps to reproduce

Proposed resolution

Right now \Drupal\automatic_updates_extensions\BatchProcessor::commit will try to delete the stage 2x if there is exception. We should copy the logic from \Drupal\automatic_updates\BatchProcessor::stage

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3436993

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow opened merge request !1044

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Parent issue: » #3436741: Make Automatic Updates Extensions stable!
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: Ensure exceptions are show if updating extensions and there is composer stager error » Ensure exceptions are shown if updating extensions and there is composer stager error
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » tedbow
Status: Needs review » Reviewed & tested by the community

One tiny thing but otherwise this is just a copy-and-paste from Automatic Updates, so I'm not concerned.

  • tedbow committed 0bd78fc9 on 3.0.x 
    Issue #3436993: Ensure exceptions are shown if updating extensions and...

  • tedbow authored 64f925e7 on 3.1.x 
    Issue #3436993: Ensure exceptions are shown if updating extensions and...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.