deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use
\Drupal\views\Entity\Render\EntityTranslationRenderTrait::getEntityTranslationByRelationship instead

CommentFileSizeAuthor
#14 interdiff.txt13.06 KBajitdalal
#2 webform_views.8.x-5.2.upgrade_status.post_rector.txt5.25 KBproject update bot
#2 webform_views.8.x-5.2.rector.patch1.04 KBproject update bot

Issue fork webform_views-3435693

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new webform_views.8.x-5.2.rector.patch1.04 KB
new webform_views.8.x-5.2.upgrade_status.post_rector.txt5.25 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !21

VladimirAus changed the visibility of the branch 3435693-automated-drupal-11 to hidden.

acbramley’s picture

acbramley commented
Issue summary: View changes
Status: Needs review » Postponed

Needs a rebase, but this is postponed until Webform officially supports D11.

We will likely need a new branch for webform_views since webform's D11 support is going into 6.3.x only

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 8.x-5.2 » 8.x-5.x-dev

Rebased.

acbramley closed merge request !21

acbramley opened merge request !30

acbramley changed the visibility of the branch project-update-bot-only to hidden.

acbramley’s picture

acbramley commented

Rerolled onto a new branch (so the bot doesn't overwrite it), slimmed down the CI file and added lenient requirements so we can test against the latest 6.3.x of webform.

mstrelan’s picture

mstrelan commented
Status: Postponed » Needs work

Webform 6.x-3.x now supports 11.x so this is no longer postponed. Needs work to remove the workarounds.

ajit dalal made their first commit to this issue’s fork.

ajit dalal opened merge request !32

ajitdalal’s picture

ajitdalal commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt13.06 KB

Fixed deprecation changes.

patelh84’s picture

patelh84 commented

#MR 32 works for D11. Tested on vailla D10 site as well. Moving it to RTBC

patelh84’s picture

patelh84 commented
Status: Needs review » Reviewed & tested by the community
tjtj’s picture

tjtj commented

so how do I install the working D11 version?

tjtj’s picture

tjtj commented

How do I get a patch to apply or a new D11 release? This is stop[ping my D11 upgrade. Webform has 6.3 out.

hassebasse’s picture

hassebasse commented

@tjtj

No they don't, just the -dev version. On stable they are still on 6.2.7.

tjtj’s picture

tjtj commented

https://www.drupal.org/project/webform/releases/6.3.x-dev

hassebasse’s picture

hassebasse commented

Yes exactly, -dev. It is not stable yet as there still are issues, at least one test that does not pass.

tjtj’s picture

tjtj commented
Priority: Normal » Major

geek-merlin closed merge request !30

geek-merlin made their first commit to this issue’s fork.

  • geek-merlin committed 1ec1904a on 8.x-5.x authored by ajitdalal 
    Issue #3435693 by vladimiraus, project update bot, ajitdalal, acbramley...
tjtj’s picture

tjtj commented

I can live with an unstable webforms, since it will be updated by composer when it is totally fixed. But I cannot do the move to D11 on a test site until you release a dev version of this module.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Reviewed & tested by the community » Fixed

Resolved und tagged 5.5

tjtj’s picture

tjtj commented
Status: Fixed » Reviewed & tested by the community

webform 6.3.0-alpha1 is released. Please release this.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

Your comment is not helpful for me to understand what you want. what is your experience, what do you like to see what is the difference?

hassebasse’s picture

hassebasse commented

tjtj

It IS released since november 23, and is tagged 8.x-5.5 and it is D11. Just to go ahead

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Thanks all for your help! 🍰

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.