Problem/Motivation

I need to alter the results of getTermIds() in \Drupal\fullcalendar_view\TaxonomyColor service but there is no way to do so unless overriding completely the fullcalendar_view.taxonomy_color.

The quickest and easiest solution is to decorate the service BUT the method is marked as `private`.

Proposed resolution

Change the method to `public`

Remaining tasks

Review MR and merge if possible.

Issue fork fullcalendar_view-3433224

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

matthieuscarset created an issue. See original summary.

matthieuscarset opened merge request !66

matthieuscarset’s picture

matthieuscarset commented
Status: Active » Closed (works as designed)

Closing this issue as this change is not really necessary.

It is easier to simply override the colorInputBoxs() method to implement custom logic.

matthieuscarset’s picture

matthieuscarset commented
Status: Closed (works as designed) » Needs review

Reopening because this small change is actually very helpful👌

I decorate TaxonomyColor to alter $elements under Taxonomy Colors options.

I need to get the list of $terms again, so I need to have getTermId() method public to be able to call it.

mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Needs review » Patch (to be ported)

Thanks @Matthieu, merged into the dev version.

mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.