Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | login_emailusername.2.1.0.rector.patch | 522 bytes | project update bot |
Issue fork login_emailusername-3431737
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
pameeela commentedManually tested this on 11.x and the module works as expected, so I think this can be merged!
Comment #6
vladimirausComment #7
vladimirausUserAuthenticationControlleras flood control was broken).@pameeela if you can give it another test, I'd appreciate it.
Seems like some functionality was broken by code not updated from UserAuthenticationController.
Comment #8
vladimirausSee change record for deprecation.
Comment #9
pameeela commentedManually tested with the latest changes:
This should be all set except there are cspell and phpcs fails.
Comment #10
Anonymous (not verified) commentedWorking onn it
Comment #11
Anonymous (not verified) commentedSolved all PHPCS and cspell errors
Added compatibility with Drupal ^12 to solve upgrade status pipeline failing when using Drupal 11
All pipelines passed with no errors or warnings
Comment #12
pameeela commentedThanks! All green now :)
Comment #13
Anonymous (not verified) commentedThank you!
Comment #14
pameeela commentedJust noting we currently have this module included in Drupal CMS. We're going to have to remove all modules that are not D11 compatible by our beta release on Nov 20. This one is easy to add back since there is no config, but figured it was worth mentioning.
Comment #16
mably commentedHi everybody, could you have a final look to this issue's MR?
I plan to merge it today and release a 3.0.0-rc1 version next.
Comment #17
Anonymous (not verified) commentedHi @mably
I checked the MR and it looks good to me. All the pipelines are passing without any warnings.
Comment #19
mably commentedVersion 3.0.0-rc1, compatible with Drupal 11, has been released!
Thanks to all!
Comment #20
pameeela commentedThank you!
Comment #22
dwwNote: probably not wise to declare D12 compatibility until D12's API is finalized. 😅 See #3503220: Premature declaration of D12 compatibility
Comment #23
vladimirausThanks @dww.
Committing. 🍻