Problem/Motivation

The cspell dictionary core/misc/cspell/dictionary.txt seems to be out of sync with reality.

Let's sync it up again.

Steps to reproduce

Proposed resolution

$ yarn spellcheck:make-dict

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3425304

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !6879

Spokje opened merge request !6881

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Spokje opened merge request !6884

Spokje closed merge request !6881

Spokje opened merge request !6885

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

mstrelan changed the visibility of the branch 3425304-10.3.x-resync-cspell-dictionary to hidden.

mstrelan changed the visibility of the branch 3425304-10.3.x-resync-cspell-dictionary to active.

mstrelan’s picture

mstrelan commented

Don't mind me, accidentally hid a branch and promptly unhid it, now wondering if "unhid" is a word.

spokje’s picture

spokje
Primary language Dutch
commented

Don't mind me, accidentally hid a branch and promptly unhid it, now wondering if "unhid" is a word.

Pretty sure it's "dehidrate", but we can't be sure until we have our spellcheck dictionary synced...

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

So on 11.x when I ran spellcheck:make-dict I didn't get the new words being added in the MR. Did get the removals.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Well spotted @smustgrave!

Apparently there were a few local config files floating around, did these runs on a clean checkout.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

That matches what I got too thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Seems a bit fast, but needs a rebase already.

spokje’s picture

spokje
Primary language Dutch
commented

Hmmm, all MRs show as mergeable in GitLab and only contain changes in one file, the cspell dictionary, that isn't touched by any of the 4 commits since the creation of the MRs AFAICT.

So is there a git-reason for a rebase I'm missing, or is it because code got deleted in the 4 mentioned MRs which should have triggered changes in the dictionary?

  • catch committed 94c8e052 on 11.x 
    Issue #3425304 by Spokje, smustgrave: Resync dictionary.txt

  • catch committed 545bd6a5 on 10.2.x 
    Issue #3425304 by Spokje, smustgrave: Resync dictionary.txt

  • catch committed dec00f6b on 10.3.x 
    Issue #3425304 by Spokje, smustgrave: Resync dictionary.txt
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.2.x-dev
Status: Needs work » Fixed

It was PEBKAC - I tried to apply the wrong MR diff to the wrong branch.

Committed/pushed to 11.x, 10.3.x, 10.2.x respectively, thanks!

catch closed merge request !6884

catch closed merge request !6885

catch closed merge request !6879

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.