Problem/Motivation

Cannot remove Overridden Setting for a content type

Steps to reproduce

Go to admin/config/content/node_revision_delete
click Configure for an overridden content type
go to Publishing options tab
unset Delete options (radio button grey)
save
(goes back to prev page)
Setting still Overridden.
Not sure if content type will be included as all custom options are off, or will be using the default values

Proposed resolution

  • Introduce a confirm form to reset settings for a node type from the node revision delete admin form
  • Add a checkbox to the node type tab for node type to indicate you want to override the settings for the the node type.
  • A browser tests and JS tests to prove this all works as expected

Remaining tasks

User interface changes

  • No longer using fieldgroups in plugin config forms - unnecessary and deprecated in Drupal 11.2 and removed in Drupal 12.
  • The vertical tab summary is more useful - tells you if the settings are overridden and if revisions are being deleted
  • New confirm form and drop button option to reset to defaults available from node revision delete admin form
  • New checkbox to indicate you want to override on the node type level on the node revision delete settings for a node type.

API changes

None

Data model changes

None

Issue fork node_revision_delete-3425134

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Jons created an issue. See original summary.

kwfinken’s picture

kwfinken commented

Same issue. Ideally a content type would have an option under Node Revision Delete settings to "handle with default schedule" which returns to the default schedule.

Currently the only way I have found to return an item to the "Default" settings is to

  1. manually edit the "node.type.<<CONTENT_TYPE>>.yml" file
    1. removing the -node_revision_delete key from the dependencies: module: section
    2. the entire node_revision_delete: section from the third_party_settings section
  2. reimport the config
kwfinken’s picture

kwfinken commented
Version: 2.0.0-beta1 » 2.0.0
Priority: Normal » Major
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 2.0.0 » 2.1.x-dev

Confirmed this is a problem.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

This occurs because node_revision_delete_form_node_type_form_builder() expects to be able to compare the node type form values with the plugin manager values from config and that's not going to work.

alexpott opened merge request !62

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes

  • alexpott committed 4651eeae on 2.1.x 
    fix: #3425134 Cannot remove Overridden Setting for a content type

By:...

alexpott opened merge request !63

  • alexpott committed 2d5e290e on 2.0.x 
    fix: #3425134 Cannot remove Overridden Setting for a content type

By:...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 2.1.x-dev » 2.0.x-dev
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This has lead to #3585263: Unable to save content types when not overriding number of revisions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.