Problem/Motivation

README.md file do not have all required informations according Drupal README Template rules.

Steps to reproduce

Download the module and compare README.md with Drupal README Template rules.

Proposed resolution

The Readme file needs to update as README Template rules.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork block_visibility_groups-3424840

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ravi kant created an issue. See original summary.

ravi kant opened merge request !10

ravi kant’s picture

ravi kant commented
Status: Active » Needs review

The MR !10 is ready to merge.

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work

Hi ravi kant

I reviewed your MR!10 and in "Introduction" you should add a module in this sentence Block Visibility Groups allows the site administrator it should be Block Visibility Groups allows module the site administrator to be more understandable. For "Recommended modules" remove the colon symbol in CTools: to be uniform with other recommended modules and missing dot in #1 and #5 in the configuration section.

Thank you

ravi kant’s picture

ravi kant commented
Status: Needs work » Needs review

@kenyoOwen
I have made changes according suggestions.

nupur badola’s picture

nupur badola commented
Status: Needs review » Needs work

Reviewed MR!10, the patch is not cleanly applied.

1. Troubleshooting and FAQ is mentioned in "##Table of contents" , however their detailed sections are not given.
Either remove them from "##Table of contents" or add their detailed section.
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Please review. Thanks.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
nupur badola’s picture

nupur badola commented
Status: Needs review » Reviewed & tested by the community

Reviewed MR!10, the file is updated as per the readme.md file template.
Hence marking it to RTBC.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3413224: Plan for Block Visibility Groups v2.1.0
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3413224: Plan for Block Visibility Groups v2.1.0 » #3465314: Plan for Block Visibility Rules 2.0.2
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 2.0.1 » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed

This is great now, thank you all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.