When you export this module configuration you will have this : 

watch_content: 0
langcode: fr
report: '{"video":{"top":["18","114"]},"wysiwyg":{"top":["23","74"]},"image":{"top":["221","221","221""]}}'

Those are the nids that contains the paragraphs, but when deploying to a new environment this info will delete the one available and give false results as the nodes ID can have changed between environment.

What is the purpose of saving and exporting this configuration in config/sync/paragraphs_report.settings.yml ?

Can it be excluded in order to avoid thos problems when deploying code ?

CommentFileSizeAuthor
#2 paragraphs_report-store-report-in-state-3423079-2.patch8.8 KBthomwilhelm

Issue fork paragraphs_report-3423079

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tostinni created an issue. See original summary.

thomwilhelm’s picture

thomwilhelm commented
StatusFileSize
new paragraphs_report-store-report-in-state-3423079-2.patch8.8 KB

Agree, report data should not be stored in configuration, as on each deployment it will be reset.

I've had a stab at moving this data to be stored in state data instead, including having an update hook to migrate this data.

I'll try running this on a few different sites shortly, if there are any issues I'll update the patch accordingly.

generalredneck made their first commit to this issue’s fork.

generalredneck opened merge request !17

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Status: Active » Needs review

@thomwilhelm,

Your patch doesn't apply cleanly against 2.x. I'm not sure, but you may have made the patch against 8.x-1.x?

In any case, I took my best attempt at merging what you had with what I had come up with before I found this issue. I added a configuration schema to square things away a bit too.

Care to give it a try? I used a different key name than you did when I initially did my changes. Let me know if it looks like I missed anything you had implemented.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

@thomwilhelm,

I think your patch contained parts of #3388513: update report data permission not working.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

Rerolled with what was in 2.x

thomwilhelm’s picture

thomwilhelm commented

Hey @generalredneck just gave PR 17 a test and all worked nicely for me, thanks for rerolling, apologies for including those lines from the other ticket.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

No problem. When I get a chance I'll get it merged in.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
miwayha’s picture

miwayha commented

I'd love to get this merged and deployed as soon as it's reasonable. Without this patch, this module has the risk to white screen on different environments that share config but may have a different database (e.g. local vs dev vs prod)

  • generalredneck committed cfda1304 on 2.x 
    Issue #3423079 by generalredneck, thomwilhelm, tostinni: Why are...
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.