Problem/Motivation

There is a files need to fixed with coding standards.
Here is the command : -
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,twig modules/contrib/auto_entitylabel/

See results in CI branch.

CommentFileSizeAuthor
#5 3422302-5.patch3.56 KBchandansha

Issue fork auto_entitylabel-3422302

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Prem Suthar created an issue. See original summary.

mohd sahzad’s picture

mohd sahzad commented
Assigned: Unassigned » mohd sahzad

Mohd Sahzad opened merge request !19

mohd sahzad’s picture

mohd sahzad commented
Assigned: mohd sahzad » Unassigned
chandansha’s picture

chandansha commented
StatusFileSize
new 3422302-5.patch3.56 KB

i fixed all phpcs issues.

pray_12’s picture

pray_12 commented

Hi,
Reviewed the above patch and found no PHPCS errors and warnings.
Thank you!!

prem suthar’s picture

prem suthar commented
Status: Active » Reviewed & tested by the community

VladimirAus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 8.x-3.0 » 8.x-3.x-dev
Priority: Minor » Normal
Status: Reviewed & tested by the community » Needs work

PHPCS returns error.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs work » Needs review
Related issues: +#3428196: Automated Drupal 11 compatibility fixes for auto_entitylabel

Ready for review.
See other CI pipelines fixed in

jannakha’s picture

jannakha commented
Status: Needs review » Needs work

tests are failing, possibly because of renamed functions:

https://git.drupalcode.org/project/auto_entitylabel/-/merge_requests/19/...
Line 44: auto_entitylabel_form_auto_entitylabel_settings_form_alter
Line 60: auto_entitylabel_auto_entitylabel_label_alter

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Issue summary: View changes
Status: Needs work » Needs review

Updated API file, brought latest changes.
Ready for review.

jannakha’s picture

jannakha commented
Status: Needs review » Reviewed & tested by the community

tests pass
CI pass
good job!

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Cheers. Committed! 🍻

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

prem suthar’s picture

prem suthar commented