Problem/Motivation

When using the admin toolbar search, clicking the links opens the URL in the current tab, and in a new tab.

Seems likely to follow on from #3162112: Make search links openable in new tabs

Steps to reproduce

1. enable admin_toolbar_search
2. type some text in the search box
3. click on the result

Expected result

The link should open in the same window and tab, unless you have chosen to open it in a new window

Actual result

The link opens in the current tab, and in a new tab.

If you use the keyboard arrows and enter key to visit the link, it does not open the extra tab.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 search_links_always_open_new_window _tab.patch838 bytesal_trottier
#6 3420788-admin_toolbar-links_same_tab.mp44.14 MBmarcoliver
#4 IssueStillPresent.mov2.16 MBdivya.sejekan

Issue fork admin_toolbar-3420788

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

malcomio created an issue. See original summary.

malcomio opened merge request !71

malcomio’s picture

malcomio commented
Status: Active » Needs review
divya.sejekan’s picture

divya.sejekan commented
Status: Needs review » Needs work
StatusFileSize
new IssueStillPresent.mov2.16 MB

@malcomio Tested using MR 3.x and also 3420788-search-links-always . The issue is not fixed, still I can see the search links are opening in both the current and new tab

marcoliver made their first commit to this issue’s fork.

marcoliver’s picture

marcoliver
he/him
Primary language German
Location Neuss, NRW, Germany
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3420788-admin_toolbar-links_same_tab.mp44.14 MB

Synced 3.x and 3420788-search-links-always in the issue fork.

Tested the behavior and it looks fine (video attached).

Marking RTBC.

al_trottier’s picture

al_trottier commented
StatusFileSize
new search_links_always_open_new_window _tab.patch838 bytes

Adding a patch with the proposed MR from #2

jannakha’s picture

jannakha commented

patch in #7 works,
please release new version

japerry made their first commit to this issue’s fork.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.