Drupal 10.2
PHP 8.2

Deprecated function: Creation of dynamic property Drupal\symfony_mailer\Email::$_symfony_mailer_log is deprecated in Drupal\symfony_mailer_log\Plugin\EmailAdjuster\LogMail->postRender() (line 92 of modules/contrib/symfony_mailer_log/src/Plugin/EmailAdjuster/LogMail.php).

CommentFileSizeAuthor
#12 3418117-12.patch591 bytessander wemagine
#5 3418117-5.patch509 bytesjrochate
#3 symfony_mailer_log-3418117.patch1015 bytesabhishek_gupta1

Issue fork symfony_mailer_log-3418117

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jcontreras created an issue. See original summary.

abhishek_gupta1’s picture

abhishek_gupta1 commented
Assigned: Unassigned » abhishek_gupta1
abhishek_gupta1’s picture

abhishek_gupta1 commented
Assigned: abhishek_gupta1 » Unassigned
Status: Active » Needs review
StatusFileSize
new symfony_mailer_log-3418117.patch1015 bytes

@jcontreras, fixed the issue and created Patch. please kindly review it.

jrochate’s picture

jrochate commented

When I added this patch, I got another error and now it's fatal:

TypeError: Drupal\symfony_mailer_log\Plugin\EmailAdjuster\LogMail::Drupal\symfony_mailer_log\Plugin\EmailAdjuster\{closure}(): Argument #1 ($address) must be of type Drupal\symfony_mailer_log\Plugin\EmailAdjuster\AddressInterface, Drupal\symfony_mailer\Address given em Drupal\symfony_mailer_log\Plugin\EmailAdjuster\LogMail->Drupal\symfony_mailer_log\Plugin\EmailAdjuster\{closure}() (linha 124 de /var/www/(...)/web/modules/contrib/symfony_mailer_log/src/Plugin/EmailAdjuster/LogMail.php).

jrochate’s picture

jrochate commented
StatusFileSize
new 3418117-5.patch509 bytes

Now it works.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

The attached patch fixes an issue with the call to getLogger() - so I have committed it.
However, the original issue reported here is the fact that we set a dynamic property:
$email->_symfony_mailer_log = $log;
This has not been resolved yet.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Needs work

justafish made their first commit to this issue’s fork.

justafish opened merge request !5

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Needs work » Needs review

Created an MR to fix the issue with the dynamic property - the LogMail object doesn't seem to get re-used when I stepped through it, so I stored the log object directly there, but maybe someone knows why that might be a bad idea 😅

sander wemagine’s picture

sander wemagine commented
StatusFileSize
new 3418117-12.patch591 bytes

I've added a patch that removes the error for us. Hopefully it can help someone else as well (until the repo is updated)

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Status: Needs review » Fixed
svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

Thanks justafish, that seems like the correct approach.
I have merged the MR now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.