Problem/Motivation

Follow-up for the kernel test with the random uids might be good yeah, just couldn't see why it was necessary and makes me wonder what I'm missing.

@catch in #3414557-10: Convert OptionsDynamicValuesValidationTest into a Kernel test

Steps to reproduce

Proposed resolution

- Search test codebase for rand( in relation to UIDs. Note that I searched the whole test codebase, not just the kernel testsuite as proposed by @catch.
- Make sure that results are absolutely intended to be random.
- If not, make them non-random, if so, leave a comment that the UIDs are intentionally random.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3415769

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

Spokje opened merge request !6236

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3414655: [META] Convert Functional tests classes which make no HTTP requests into Kernel tests , +#3414557: Convert OptionsDynamicValuesValidationTest into a Kernel test
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Using phpstorm insepector searched for rand( and went through some of the findings and believe the changes make sense.

  • catch committed b31bcec2 on 11.x 
    Issue #3415769 by Spokje, smustgrave: Use random user IDs in tests only...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This looks good to me too, thanks for adding the comments to the ones we actually need to keep.

Spokje closed merge request !6236

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.