Problem/Motivation

\Drupal\Tests\options\Functional\OptionsDynamicValuesValidationTest Makes no HTTP requests but is a functional test.

Steps to reproduce

Proposed resolution

Convert \Drupal\Tests\options\Functional\OptionsDynamicValuesValidationTest into a Kernel test.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3414557

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !6155

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Parent issue: » #3414655: [META] Convert Functional tests classes which make no HTTP requests into Kernel tests
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Conversion seems good, coverage still appears to be there.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Question on the MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Noted that user IDs shouldn't be random.

Update seems done.

  • catch committed edf50e18 on 10.2.x 
    Issue #3414557 by Spokje: Convert OptionsDynamicValuesValidationTest...

  • catch committed 078c284c on 11.x 
    Issue #3414557 by Spokje: Convert OptionsDynamicValuesValidationTest...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Follow-up for the kernel test with the random uids might be good yeah, just couldn't see why it was necessary and makes me wonder what I'm missing.

Committed/pushed to 11.x and cherry-picked to 10.2.x, thanks!

Spokje closed merge request !6155

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3415769: Use random user IDs in tests only only when intended to

Opened #3415769: Use random user IDs in tests only only when intended to as for the above comment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.