Problem/motivation

Test coverage in UrlEmbedTestBase.php was written 8 years ago to accommodate how Drupal's htmlcorrector filter behaves, and the code included a @todo to remove it when #1333730: [Meta] PHP DOM (libxml2) misinterprets HTML5 was fixed:

/**
* The expected output of the Flickr URL in a WYSIWYG.
*
* Embeds rendered via the url_embed filter generate XHTML4 markup due to
* deficiencies with libxml2.
*
* @todo Remove once https://www.drupal.org/node/1333730 lands.
*/

As a result, tests currently fail on Drupal 10.2.x

Proposed resolution

Update the test coverage to expect standard HTML5 output.

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.

Issue fork url_embed-3413595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mark_fullmer created an issue. See original summary.

mark_fullmer opened merge request !12

  • mark_fullmer committed eaf56deb on 2.x 
    Issue #3413595: Update test coverage relating to libxml2 library
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Active » Fixed

With the syntax change to match HTML5 expectations, tests pass on Gitlab CI.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.