Problem/Motivation

Following a composer update and subsequent raising of Attribution to 1.0.10, AFTER A CACHE CLEAR, my site is knocked out with...

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "attribution.copyright_subscriber" has a dependency on a non-existent service "logger.channel.webfinger".

After the cache clear (UI or drush), any attempt to visit any pages result in the above.

The file...

modules/contrib/attribution/src/EventSubscriber/WebfingerAttributionSubscriber.php

... is present but not happy.

TEMP FIX

Commenting out the declaration of the service in the attribution.services.yml file ...

services:
#  attribution.copyright_subscriber:
#    class: Drupal\attribution\EventSubscriber\WebfingerAttributionSubscriber
#    arguments: ['@current_user', '@entity_type.manager', '@logger.channel.webfinger']
#    tags:
#      - { name: 'event_subscriber' }

Relieves the pain.

Looking a little deeper, I see that the service code has not been installed...

no-drupal-slash-webfinger-code

Is this simply a composer.json dependency issue?

CommentFileSizeAuthor
#2 no-drupal-slash-webfinger-code.png48.13 KBsirclickalot
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

SirClickalot created an issue. See original summary.

sirclickalot’s picture

Issue summary: View changes
StatusFileSize
new48.13 KB
sirclickalot’s picture

Issue summary: View changes
sirclickalot’s picture

Title: Site dead after update to 1.0.10 » Missing drupal/webfinger after module update to 1.0.10

sanduhrs made their first commit to this issue’s fork.

  • sanduhrs committed 3f83df95 on 1.0.x
    Issue #3411993 by sanduhrs: Missing drupal/webfinger after module update...
sanduhrs’s picture

Version: 1.0.10 » 1.0.x-dev
Status: Active » Fixed

Committed to -dev, fixed in next release.
Thanks for reporting.

  • sanduhrs committed 4718c9c1 on 1.0.x
    Issue #3411993 by sanduhrs: Missing drupal/webfinger after module update...
noah’s picture

Version: 1.0.x-dev » 1.0.11
Status: Fixed » Needs work

I was still seeing the error with 1.0.11, because although drupal/webfinger was being downloaded (thanks to the dependency added in this issue), the module was not enabled so none of the referenced methods were available. I was able to get the site working again by following @SirClickalot's instructions re: commenting out the service in attribution.services.yml, manually enabling the Webfinger module, and then re-enabling the service.

Unless I've missed something about how this should work, I think the Webfinger module should be listed as a dependency in attribution.info.yml, no? And I think there should be an attribution.install file with a hook to ensure that the Webfinger module is enabled. I'd be up for making these updates, however I'm not even sure that will do it since the error here is preventing database updates from running (so the "enable Webfinger" hook won't run because of the error caused by Webfinger not being enabled)—I'm not sure how to work around that.

  • sanduhrs committed 24928aa4 on 1.0.x
    Revert "Issue #3411993 by sanduhrs: Missing drupal/webfinger after...
sanduhrs’s picture

Status: Needs work » Fixed

The webfinger support has been reverted FTTB.
Thanks for reporting!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.