Problem/Motivation

Rewrite to use common table expressions per https://github.com/nterbogt/entity_hierarchy/pull/2

Steps to reproduce

Proposed resolution

Remaining tasks

  1. See if we can do something with the views arguments, as they're useful
  2. hook_requirements to prevent install if no support for CTEs

User interface changes

API changes

Data model changes

Issue fork entity_hierarchy-3411981

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan credited nterbogt.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 4.x-dev » 5.x-dev
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

larowlan opened merge request !26

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

This is passing now.
Taking a quick look at the views integration to see if there's any quick wins

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I have the 'is child of' argument for views going, will round out the 'is parent of' and 'is sibling of' as those are simple enough.

Then will add the hook_requirements and I think this is good to go.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Pushed arguments to add-back-views branch
Will get tests passing tomorrow and move onto hook_requirements

  • larowlan committed 552e275c on 5.x 
    Issue #3411981 by larowlan, nterbogt: CTE Rewrite
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue summary: View changes
Status: Active » Fixed

Merged!

Thanks for the monster effort @nterbogt

I'll cut an alpha and add some issues for some possible things we could do before beta

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.