Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3410450

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Title: Random performance test failures » Fix random performance test failures
Priority: Normal » Critical
Status: Active » Needs review

#3410312: Flood database backend ::isAllowed() should call ::ensureTableExists() likely caused this. The exceptions in the lazy creation table logic mean that the original query that triggered the exception (like FloodInterface::isAllowed()) don't get recorded, so that issue removes less observable queries than it does actual queries that run during tests.

catch opened merge request !5932

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Thanks

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Closed (duplicate)

This ended up being included in #3410419: Only clear flood attempts when necessary during user login which I wasn't expecting to land first.

catch’s picture

catch
he/him
Primary language English
commented
Status: Closed (duplicate) » Needs review

No we do need to tweak it after all. https://git.drupalcode.org/project/drupal/-/jobs/529691

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Reviewed & tested by the community

Hopefully this is enough.

  • larowlan committed bdc1f78b on 11.x 
    Issue #3410450 by catch: Fix random performance test failures

  • larowlan committed 51ebf197 on 10.2.x 
    Issue #3410450 by catch: Fix random performance test failures

(cherry...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x

Backported to 10.2.x because the related issues also were, so I assume the issue also exists there.

larowlan closed merge request !5932

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.