Problem/Motivation
Remove book from comments in preparation for deprecating the module
Steps to reproduce
$ grep --exclude-dir={fixtures,book,node_modules,vendor,themes} -ri ".*\*.*book.*" core | grep -vi migrat | grep -iw book | awk -F: '{print $1}' | sort -u | nl
1 core/lib/Drupal/Core/Config/ConfigInstallerInterface.php
2 core/lib/Drupal/Core/Controller/ControllerBase.php
3 core/lib/Drupal/Core/Database/Connection.php
4 core/lib/Drupal/Core/Entity/entity.api.php
5 core/lib/Drupal/Core/Form/ConfigFormBaseTrait.php
6 core/lib/Drupal/Core/Form/FormBase.php
7 core/lib/Drupal/Core/Menu/menu.api.php
8 core/lib/Drupal/Core/Password/PhpPassword.php
9 core/lib/Drupal.php
10 core/modules/block/block.api.php
11 core/modules/comment/comment.module
12 core/modules/comment/tests/src/Functional/CommentBookTest.php
13 core/modules/field/src/Entity/FieldStorageConfig.phpProposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Issue fork drupal-3409407
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3409407-remove-book-module
changes, plain diff MR !5854
Comments
Comment #3
quietone commentedComment #4
smustgrave commentedApplied the MR and ran the search and there are 4 returns
1 core/lib/Drupal/Core/Database/Connection.php = Not related to module
2 core/lib/Drupal/Core/Password/PhpPassword.php = Not related to module
3 core/modules/comment/comment.module = Not related to module
4 core/modules/comment/tests/src/Functional/CommentBookTest.php = IS related to the module
I'm making an assumption that CommentBookTest will be fixed when tests are moved.
Comment #5
quietone commentedIt is being done in #3376271: Move non-migration book-related tests to the Book module
Comment #6
longwaveMR no longer applies and needs rebasing.
Comment #7
quietone commentedThere were conflicts in two files but it was straightforward.
Comment #8
smustgrave commentedRebase seems good.
Comment #9
longwavetest.sh from the hook_help accessibility issue has been accidentally added.
Comment #10
quietone commentedRight, that is what happens when you make a simple change just before going to be.
Should be fixed now.
Comment #11
quietone commentedComment #12
smustgrave commentedMy mistake in #8, saw green.
See test.sh is removed.
Comment #13
xjmThis looks good overall. I left one suggestion on the MR for a comment that went weird, and another question.
Thanks!
Comment #14
xjmAlso, I looked at the remaining usages and I think we should also update this bit from
comment.module:Comment #15
xjmAlso, this issue seems to address docblock comments, but there are still a number of inline comments that also reference the book module:
Some of those are not relevant, but others definitely reference the Book module.
Saving credits.
Comment #16
xjmComment #17
quietone commentedThe usages in book in comments listed in #15 are all in tests and tests are done in separate issues. We have already done one #3376369: Remove use of book in non profile and update tests. I just made one for the tests in #15, #3414637: Remove usages of book module from tests.
Updating the title for clarity.
Comment #18
smustgrave commentedChanges appear to have been addressed.
Liked the replacement of "my_module.settings" that should stand the test of time and any future deprecations.
Comment #20
larowlanThanks folks.
Looks good to me
Committed to 11.x